[PR #330] [MERGED] log improvement ThrowInvalidType #1488

New issue

Closed

opened 2026-02-27 21:12:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/330
Author: @DanielSvoboda
Created: 7/28/2024
Status: ✅ Merged
Merged: 7/28/2024
Merged by: @raphaelthegreat

Base: main ← Head: log-improvement-ThrowInvalidType

📝 Commits (2)

7edd293 log improvement ThrowInvalidType
cf2a167 log improvement ThrowInvalidType

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 src/shader_recompiler/ir/ir_emitter.cpp (+7 -2)

📄 Description

Helps with debugging, makes it easier to locate which function generated the error in this code

BEFORE:

[Debug] <Critical> ir_emitter.cpp:ThrowInvalidType:12: Unreachable code!
Invalid type 256

AFTER:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/330 **Author:** [@DanielSvoboda](https://github.com/DanielSvoboda) **Created:** 7/28/2024 **Status:** ✅ Merged **Merged:** 7/28/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `log-improvement-ThrowInvalidType` --- ### 📝 Commits (2) - [`7edd293`](https://github.com/shadps4-emu/shadPS4/commit/7edd2932011c1518abc6d99ced35afebd535a27f) log improvement ThrowInvalidType - [`cf2a167`](https://github.com/shadps4-emu/shadPS4/commit/cf2a1679435f4967f638e3ec8adb07b43931096a) log improvement ThrowInvalidType ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/ir/ir_emitter.cpp` (+7 -2) </details> ### 📄 Description Helps with debugging, makes it easier to locate which function generated the error in this code BEFORE: ``` [Debug] <Critical> ir_emitter.cpp:ThrowInvalidType:12: Unreachable code! Invalid type 256 ``` AFTER: ![image](https://github.com/user-attachments/assets/36d72bfe-cb36-41c2-9b59-adbb72015889) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>