[PR #266] [MERGED] Added Legacy Min/Max ops #1437

New issue

Closed

opened 2026-02-27 21:12:33 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/266
Author: @CoreyHendrey
Created: 7/8/2024
Status: ✅ Merged
Merged: 7/8/2024
Merged by: @raphaelthegreat

Base: main ← Head: v_max_legacy_f32

📝 Commits (7)

5fb94c9 Forwarding V_MAX_LEGACY_F32 to V_MAX3_F32. Fixes Translation error in Geometry Wars 3.
c279e9e Forwarded to correct op
86f403a Implemented Legacy Max/Min using NMax/NMin
ccea0e0 Added extra argument to Min/Max op codes
6a4b11e Merge branch 'shadps4-emu:main' into v_max_legacy_f32
3262e63 Removed extra translator functions, replaced with bool
7bd993b Formatting

📊 Changes

8 files changed (+39 additions, -18 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_floating_point.cpp (+10 -2)
📝 src/shader_recompiler/backend/spirv/emit_spirv_instructions.h (+2 -2)
📝 src/shader_recompiler/frontend/translate/translate.cpp (+6 -0)
📝 src/shader_recompiler/frontend/translate/translate.h (+2 -2)
📝 src/shader_recompiler/frontend/translate/vector_alu.cpp (+4 -4)
📝 src/shader_recompiler/ir/ir_emitter.cpp (+11 -4)
📝 src/shader_recompiler/ir/ir_emitter.h (+2 -2)
📝 src/shader_recompiler/ir/opcodes.inc (+2 -2)

📄 Description

Now using NMin and NMax to match the AMD specs for Legacy versions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/266 **Author:** [@CoreyHendrey](https://github.com/CoreyHendrey) **Created:** 7/8/2024 **Status:** ✅ Merged **Merged:** 7/8/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `v_max_legacy_f32` --- ### 📝 Commits (7) - [`5fb94c9`](https://github.com/shadps4-emu/shadPS4/commit/5fb94c92dbbce9b6909e6e1b9721b238e437fc05) Forwarding V_MAX_LEGACY_F32 to V_MAX3_F32. Fixes Translation error in Geometry Wars 3. - [`c279e9e`](https://github.com/shadps4-emu/shadPS4/commit/c279e9e6f4a2aa72229d359cd27b73b46edce6c5) Forwarded to correct op - [`86f403a`](https://github.com/shadps4-emu/shadPS4/commit/86f403aaf92b01356e08f7c6f1c77ae49aa58a4a) Implemented Legacy Max/Min using NMax/NMin - [`ccea0e0`](https://github.com/shadps4-emu/shadPS4/commit/ccea0e0e9f0ffb6445a9a30a463d76ee79cef2b9) Added extra argument to Min/Max op codes - [`6a4b11e`](https://github.com/shadps4-emu/shadPS4/commit/6a4b11eae6099847c568981a26243d206bec9a5f) Merge branch 'shadps4-emu:main' into v_max_legacy_f32 - [`3262e63`](https://github.com/shadps4-emu/shadPS4/commit/3262e638ed31def447464d30c5e1b9e11b1789d8) Removed extra translator functions, replaced with bool - [`7bd993b`](https://github.com/shadps4-emu/shadPS4/commit/7bd993bedfea4bb21882cd38abaebf655b8889b2) Formatting ### 📊 Changes **8 files changed** (+39 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_floating_point.cpp` (+10 -2) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_instructions.h` (+2 -2) 📝 `src/shader_recompiler/frontend/translate/translate.cpp` (+6 -0) 📝 `src/shader_recompiler/frontend/translate/translate.h` (+2 -2) 📝 `src/shader_recompiler/frontend/translate/vector_alu.cpp` (+4 -4) 📝 `src/shader_recompiler/ir/ir_emitter.cpp` (+11 -4) 📝 `src/shader_recompiler/ir/ir_emitter.h` (+2 -2) 📝 `src/shader_recompiler/ir/opcodes.inc` (+2 -2) </details> ### 📄 Description Now using NMin and NMax to match the AMD specs for Legacy versions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>