[PR #258] [CLOSED] sceSaveDataDirNameSearch: Removed early failure exit #1430

New issue

Closed

opened 2026-02-27 21:12:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/258
Author: @CoreyHendrey
Created: 7/7/2024
Status: ❌ Closed

Base: main ← Head: gw3_save_fix

📝 Commits (1)

7546fb2 sceSaveDataDirNameSearch: Removed early failure exit

📊 Changes

1 file changed (+5 additions, -6 deletions)

View changed files

📝 src/core/libraries/save_data/savedata.cpp (+5 -6)

📄 Description

Geometry wars will throw a save corrupt error with this early exit, however, if functions perfectly if we let this flow through.
I am not sure why the early exit was implemented originally, was it just to make sure the log didn't throw an nullptr exception?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/258 **Author:** [@CoreyHendrey](https://github.com/CoreyHendrey) **Created:** 7/7/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `gw3_save_fix` --- ### 📝 Commits (1) - [`7546fb2`](https://github.com/shadps4-emu/shadPS4/commit/7546fb2bb5c63fcfd355a95f5be30b7295c72b24) sceSaveDataDirNameSearch: Removed early failure exit ### 📊 Changes **1 file changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/save_data/savedata.cpp` (+5 -6) </details> ### 📄 Description Geometry wars will throw a save corrupt error with this early exit, however, if functions perfectly if we let this flow through. I am not sure why the early exit was implemented originally, was it just to make sure the log didn't throw an nullptr exception? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>