[PR #253] [MERGED] Graphics: missing features and fixes #1425

New issue

Closed

opened 2026-02-27 21:12:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/253
Author: @psucien
Created: 7/6/2024
Status: ✅ Merged
Merged: 7/7/2024
Merged by: @georgemoralis

Base: main ← Head: graphics/features_and_fixes

📝 Commits (7)

986ed06 gnmdriver, amdgpu: added gpu idle IRQ; submission lock logic improved
cfbe8b9 renderer: added support for instance step rates
1d60842 renderer: don't let unbound color attachment affect pass's rendering area
bf4bf4c recompiler: fix for gather4 components return
19c85c7 recompiler: switch instance data to storage buffers
c7af8df gnmdriver: added sceGnmFindResourcesPublic stub
6dbb842 renderer: a bit more formats to support

📊 Changes

17 files changed (+192 additions, -71 deletions)

View changed files

📝 src/core/libraries/gnmdriver/gnmdriver.cpp (+26 -19)
📝 src/core/libraries/gnmdriver/gnmdriver.h (+1 -1)
📝 src/core/platform.h (+1 -0)
📝 src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp (+26 -8)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+47 -6)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.h (+3 -0)
📝 src/shader_recompiler/frontend/translate/translate.cpp (+18 -4)
📝 src/shader_recompiler/frontend/translate/vector_memory.cpp (+4 -3)
📝 src/shader_recompiler/runtime_info.h (+3 -1)
📝 src/video_core/amdgpu/liverpool.cpp (+1 -12)
📝 src/video_core/amdgpu/liverpool.h (+6 -10)
📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+10 -0)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+20 -2)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+8 -4)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+1 -1)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+13 -0)
📝 src/video_core/texture_cache/tile_manager.cpp (+4 -0)

📄 Description

Added complete instancing support
Fixed a lock for games polling sceGnmAreSubmitsAllowed
Fix for partial clears when previous smaller attachments were bound
Fix for gather4 results data
Added sceGnmFindResourcesPublic (https://github.com/shadps4-emu/shadps4-game-compatibility/issues/25)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/253 **Author:** [@psucien](https://github.com/psucien) **Created:** 7/6/2024 **Status:** ✅ Merged **Merged:** 7/7/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `graphics/features_and_fixes` --- ### 📝 Commits (7) - [`986ed06`](https://github.com/shadps4-emu/shadPS4/commit/986ed0662c024f0772b2aeb8725c751276d5d2b1) gnmdriver, amdgpu: added gpu idle IRQ; submission lock logic improved - [`cfbe8b9`](https://github.com/shadps4-emu/shadPS4/commit/cfbe8b9e6d413cea9138386428866fd282d9a041) renderer: added support for instance step rates - [`1d60842`](https://github.com/shadps4-emu/shadPS4/commit/1d608427ed996b6491037b5de0d1a8ea57b8eb69) renderer: don't let unbound color attachment affect pass's rendering area - [`bf4bf4c`](https://github.com/shadps4-emu/shadPS4/commit/bf4bf4ccb2ec5996d31e52ad570e6da00a9d6b04) recompiler: fix for gather4 components return - [`19c85c7`](https://github.com/shadps4-emu/shadPS4/commit/19c85c78cf7cdb7097222b2c4fb113188ad5a911) recompiler: switch instance data to storage buffers - [`c7af8df`](https://github.com/shadps4-emu/shadPS4/commit/c7af8df2ad925540f597173e47c5ff637f15ab7a) gnmdriver: added `sceGnmFindResourcesPublic` stub - [`6dbb842`](https://github.com/shadps4-emu/shadPS4/commit/6dbb842bec3a63c68a22abb516818d7539961d2f) renderer: a bit more formats to support ### 📊 Changes **17 files changed** (+192 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/gnmdriver/gnmdriver.cpp` (+26 -19) 📝 `src/core/libraries/gnmdriver/gnmdriver.h` (+1 -1) 📝 `src/core/platform.h` (+1 -0) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp` (+26 -8) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+47 -6) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.h` (+3 -0) 📝 `src/shader_recompiler/frontend/translate/translate.cpp` (+18 -4) 📝 `src/shader_recompiler/frontend/translate/vector_memory.cpp` (+4 -3) 📝 `src/shader_recompiler/runtime_info.h` (+3 -1) 📝 `src/video_core/amdgpu/liverpool.cpp` (+1 -12) 📝 `src/video_core/amdgpu/liverpool.h` (+6 -10) 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+10 -0) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+20 -2) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+8 -4) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+1 -1) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+13 -0) 📝 `src/video_core/texture_cache/tile_manager.cpp` (+4 -0) </details> ### 📄 Description * Added complete instancing support * Fixed a lock for games polling `sceGnmAreSubmitsAllowed` * Fix for partial clears when previous smaller attachments were bound * Fix for gather4 results data * Added `sceGnmFindResourcesPublic` (https://github.com/shadps4-emu/shadps4-game-compatibility/issues/25) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>