[PR #247] [MERGED] Improve physical device selection in Vulkan renderer #1421

Closed
opened 2026-02-27 21:12:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/247
Author: @viniciuslrangel
Created: 7/6/2024
Status: Merged
Merged: 7/8/2024
Merged by: @psucien

Base: mainHead: device-selector


📝 Commits (1)

  • 6cc8381 Improve physical device selection in Vulkan renderer

📊 Changes

1 file changed (+25 additions, -5 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.cpp (+25 -5)

📄 Description

Fix when two discrete gpu are present & memory heap size is now considered while sorting physical devices

Hello, it's my first contribution. Feel free to criticise


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/247 **Author:** [@viniciuslrangel](https://github.com/viniciuslrangel) **Created:** 7/6/2024 **Status:** ✅ Merged **Merged:** 7/8/2024 **Merged by:** [@psucien](https://github.com/psucien) **Base:** `main` ← **Head:** `device-selector` --- ### 📝 Commits (1) - [`6cc8381`](https://github.com/shadps4-emu/shadPS4/commit/6cc8381d6216781be04b1dab703f751a6043ec10) Improve physical device selection in Vulkan renderer ### 📊 Changes **1 file changed** (+25 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+25 -5) </details> ### 📄 Description Fix when two discrete gpu are present & memory heap size is now considered while sorting physical devices Hello, it's my first contribution. Feel free to criticise --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:12:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#1421
No description provided.