[PR #213] [MERGED] A better stub for trophies #1399

New issue

Closed

opened 2026-02-27 21:12:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/213
Author: @psucien
Created: 6/25/2024
Status: ✅ Merged
Merged: 6/25/2024
Merged by: @georgemoralis

Base: main ← Head: hle/trophies

📝 Commits (5)

8475a62 common: Common namespace for the slot vector container
acc4ef7 common: slot_vector: added is_allocated to check if the slot already exists
ff64dd7 libraries: trophy: a better stubs implementation
3b2a312 kernel: thread_management: silence compilation warning
9b3a894 fix for Linux build

📊 Changes

9 files changed (+92 additions, -23 deletions)

View changed files

📝 src/common/slot_vector.h (+9 -5)
📝 src/core/libraries/error_codes.h (+7 -0)
📝 src/core/libraries/gnmdriver/gnmdriver.cpp (+1 -1)
📝 src/core/libraries/kernel/thread_management.cpp (+1 -0)
📝 src/core/libraries/np_trophy/np_trophy.cpp (+64 -8)
📝 src/core/libraries/np_trophy/np_trophy.h (+5 -4)
📝 src/video_core/texture_cache/image.h (+1 -1)
📝 src/video_core/texture_cache/texture_cache.h (+2 -2)
📝 src/video_core/texture_cache/types.h (+2 -2)

📄 Description

With the existing implementation, when a guest app tries to obtain a handler, we return a handle allocation error. These changes mock correct handle and context allocation, since some of the games rely on a valid state of trophies system.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/213 **Author:** [@psucien](https://github.com/psucien) **Created:** 6/25/2024 **Status:** ✅ Merged **Merged:** 6/25/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `hle/trophies` --- ### 📝 Commits (5) - [`8475a62`](https://github.com/shadps4-emu/shadPS4/commit/8475a62a46dfbfaff89b656998b803983494bb3f) common: `Common` namespace for the slot vector container - [`acc4ef7`](https://github.com/shadps4-emu/shadPS4/commit/acc4ef7b4ce4c7ab8090e916243a49806a652a00) common: slot_vector: added `is_allocated` to check if the slot already exists - [`ff64dd7`](https://github.com/shadps4-emu/shadPS4/commit/ff64dd74f6ed68b2c7a59011633db1ff5136a66b) libraries: trophy: a better stubs implementation - [`3b2a312`](https://github.com/shadps4-emu/shadPS4/commit/3b2a312f1540d3a523824145f95c13777f9f805e) kernel: thread_management: silence compilation warning - [`9b3a894`](https://github.com/shadps4-emu/shadPS4/commit/9b3a89467e1903112b2dcb479a8799d244ab869b) fix for Linux build ### 📊 Changes **9 files changed** (+92 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/common/slot_vector.h` (+9 -5) 📝 `src/core/libraries/error_codes.h` (+7 -0) 📝 `src/core/libraries/gnmdriver/gnmdriver.cpp` (+1 -1) 📝 `src/core/libraries/kernel/thread_management.cpp` (+1 -0) 📝 `src/core/libraries/np_trophy/np_trophy.cpp` (+64 -8) 📝 `src/core/libraries/np_trophy/np_trophy.h` (+5 -4) 📝 `src/video_core/texture_cache/image.h` (+1 -1) 📝 `src/video_core/texture_cache/texture_cache.h` (+2 -2) 📝 `src/video_core/texture_cache/types.h` (+2 -2) </details> ### 📄 Description With the existing implementation, when a guest app tries to obtain a handler, we return a handle allocation error. These changes mock correct handle and context allocation, since some of the games rely on a valid state of trophies system. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>