[PR #169] [MERGED] Stabilization & bugfixes #1357

New issue

Closed

opened 2026-02-27 21:12:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/169
Author: @psucien
Created: 6/6/2024
Status: ✅ Merged
Merged: 6/7/2024
Merged by: @georgemoralis

Base: main ← Head: stabilization_two

📝 Commits (8)

6814d5f renderer_vulkan: fix for vertex buffer mapping offset
729d02d renderer_vulkan: proper min uniform alignment
cb07778 renderer_vulkan: proper barriers
b17b4ab texture_cache: detiler: redundant flag removed
cfc2976 texture_cache: fix for forgotten cb tiling info update
e790ec7 texture_cache: detiler: more verbosity in print
dd5a25f review iteration
fe3b546 renderer_vulkan, config: option to toggle VK validation layer

📊 Changes

17 files changed (+194 additions, -96 deletions)

View changed files

📝 src/common/config.cpp (+21 -0)
📝 src/common/config.h (+3 -0)
📝 src/video_core/amdgpu/resource.h (+16 -0)
📝 src/video_core/renderer_vulkan/renderer_vulkan.cpp (+2 -2)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.cpp (+2 -10)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+72 -34)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+1 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+6 -3)
📝 src/video_core/renderer_vulkan/vk_instance.h (+3 -2)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+1 -6)
📝 src/video_core/renderer_vulkan/vk_platform.cpp (+30 -10)
📝 src/video_core/renderer_vulkan/vk_stream_buffer.cpp (+8 -0)
📝 src/video_core/renderer_vulkan/vk_stream_buffer.h (+3 -0)
📝 src/video_core/texture_cache/image.cpp (+6 -5)
📝 src/video_core/texture_cache/image_view.h (+0 -1)
📝 src/video_core/texture_cache/texture_cache.cpp (+15 -9)
📝 src/video_core/texture_cache/tile_manager.cpp (+5 -14)

📄 Description

This PR addresses the next issues found in the recent emulator version:

Possible incorrect offset for vertex buffer binding
Missing barriers (this should change games art direction on gmoralis's PC)
Uniform buffer offset now is device dependent

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/169 **Author:** [@psucien](https://github.com/psucien) **Created:** 6/6/2024 **Status:** ✅ Merged **Merged:** 6/7/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `stabilization_two` --- ### 📝 Commits (8) - [`6814d5f`](https://github.com/shadps4-emu/shadPS4/commit/6814d5f108cb077171e8085c36242c4a24a83acf) renderer_vulkan: fix for vertex buffer mapping offset - [`729d02d`](https://github.com/shadps4-emu/shadPS4/commit/729d02d699831868d16c7eaec1d8ca4c6c296921) renderer_vulkan: proper min uniform alignment - [`cb07778`](https://github.com/shadps4-emu/shadPS4/commit/cb077780085bf245bd0dc2431caee035e023ba35) renderer_vulkan: proper barriers - [`b17b4ab`](https://github.com/shadps4-emu/shadPS4/commit/b17b4ab787f315d5464022fca1e9d0a015f906e9) texture_cache: detiler: redundant flag removed - [`cfc2976`](https://github.com/shadps4-emu/shadPS4/commit/cfc297622fd771bd6405440f69864d6ca4b114a9) texture_cache: fix for forgotten cb tiling info update - [`e790ec7`](https://github.com/shadps4-emu/shadPS4/commit/e790ec775fcc3a1c586cbdb62341dc4bee8a67d9) texture_cache: detiler: more verbosity in print - [`dd5a25f`](https://github.com/shadps4-emu/shadPS4/commit/dd5a25fda2d5b65a4fe262c8362ba0abcff585bc) review iteration - [`fe3b546`](https://github.com/shadps4-emu/shadPS4/commit/fe3b546d939a8cd27c47849056b5795a69023659) renderer_vulkan, config: option to toggle VK validation layer ### 📊 Changes **17 files changed** (+194 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+21 -0) 📝 `src/common/config.h` (+3 -0) 📝 `src/video_core/amdgpu/resource.h` (+16 -0) 📝 `src/video_core/renderer_vulkan/renderer_vulkan.cpp` (+2 -2) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.cpp` (+2 -10) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+72 -34) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+6 -3) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+3 -2) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+1 -6) 📝 `src/video_core/renderer_vulkan/vk_platform.cpp` (+30 -10) 📝 `src/video_core/renderer_vulkan/vk_stream_buffer.cpp` (+8 -0) 📝 `src/video_core/renderer_vulkan/vk_stream_buffer.h` (+3 -0) 📝 `src/video_core/texture_cache/image.cpp` (+6 -5) 📝 `src/video_core/texture_cache/image_view.h` (+0 -1) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+15 -9) 📝 `src/video_core/texture_cache/tile_manager.cpp` (+5 -14) </details> ### 📄 Description This PR addresses the next issues found in the recent emulator version: * Possible incorrect offset for vertex buffer binding * Missing barriers (this should change games art direction on gmoralis's PC) * Uniform buffer offset now is device dependent --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>