[PR #163] [MERGED] Basic detiling #1355

New issue

Closed

opened 2026-02-27 21:12:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/163
Author: @psucien
Created: 6/5/2024
Status: ✅ Merged
Merged: 6/5/2024
Merged by: @georgemoralis

Base: main ← Head: video_core/surface_works

📝 Commits (10+)

863d80c fix for name of the first dumped cmdb
23cc60b video_core: amdgpu: simply crash if an exception occured in coro
d7d324a amdgpu: surface bits per element LUT
d491bbf amdgpu: tiling mode introduced
cd87005 renderer_vulkan: unused extension removed
2c87171 texture_cache: a support for m8x1 and m8x4 layouts added to the detiler
184b7b7 video_core: added shader header files generator from Citra
440a60a texture_cache: detiler: m8x1 and m8x4 shaders
1999442 texture_cache: detiler: shader module release and debug name
0b63a76 amdgpu: render target size hint for old runtime

📊 Changes

22 files changed (+612 additions, -98 deletions)

View changed files

📝 CMakeLists.txt (+7 -0)
📝 src/core/libraries/gnmdriver/gnmdriver.cpp (+1 -1)
📝 src/video_core/amdgpu/liverpool.cpp (+1 -1)
📝 src/video_core/amdgpu/liverpool.h (+21 -2)
📝 src/video_core/amdgpu/pixel_format.cpp (+17 -4)
📝 src/video_core/amdgpu/pixel_format.h (+2 -1)
📝 src/video_core/amdgpu/resource.h (+20 -1)
➕ src/video_core/host_shaders/CMakeLists.txt (+42 -0)
➕ src/video_core/host_shaders/StringShaderHeader.cmake (+36 -0)
➕ src/video_core/host_shaders/detile_m8x1.comp (+48 -0)
➕ src/video_core/host_shaders/detile_m8x4.comp (+57 -0)
➕ src/video_core/host_shaders/source_shader.h.in (+14 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+0 -8)
📝 src/video_core/renderer_vulkan/vk_instance.h (+0 -6)
📝 src/video_core/texture_cache/image.cpp (+30 -9)
📝 src/video_core/texture_cache/image.h (+6 -0)
📝 src/video_core/texture_cache/image_view.cpp (+8 -2)
📝 src/video_core/texture_cache/image_view.h (+5 -2)
📝 src/video_core/texture_cache/texture_cache.cpp (+56 -54)
📝 src/video_core/texture_cache/texture_cache.h (+9 -5)

...and 2 more files

📄 Description

This PR adds a simple detiler for 2D textures (1 and 4 channels only by now) as well as small bug fixes here and there.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/163 **Author:** [@psucien](https://github.com/psucien) **Created:** 6/5/2024 **Status:** ✅ Merged **Merged:** 6/5/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `video_core/surface_works` --- ### 📝 Commits (10+) - [`863d80c`](https://github.com/shadps4-emu/shadPS4/commit/863d80c16c7bc36b1891cc4239833fca6abad626) fix for name of the first dumped cmdb - [`23cc60b`](https://github.com/shadps4-emu/shadPS4/commit/23cc60bf06740bd08b59959d7ffb46c173229087) video_core: amdgpu: simply crash if an exception occured in coro - [`d7d324a`](https://github.com/shadps4-emu/shadPS4/commit/d7d324ac76aa13b50ae722519c12fe46e02fd2dc) amdgpu: surface bits per element LUT - [`d491bbf`](https://github.com/shadps4-emu/shadPS4/commit/d491bbf366eda2fc0108e391a9674aecff46d8b9) amdgpu: tiling mode introduced - [`cd87005`](https://github.com/shadps4-emu/shadPS4/commit/cd87005ded6678bd4c2065a7410d99fadfd9097c) renderer_vulkan: unused extension removed - [`2c87171`](https://github.com/shadps4-emu/shadPS4/commit/2c87171b95ee68d82f5efdf7563af5b233caad5f) texture_cache: a support for m8x1 and m8x4 layouts added to the detiler - [`184b7b7`](https://github.com/shadps4-emu/shadPS4/commit/184b7b7fc2d66e74f995fdff7a92af6e0b6bd669) video_core: added shader header files generator from Citra - [`440a60a`](https://github.com/shadps4-emu/shadPS4/commit/440a60a43bf113b5965f6a9aa56d6ff39bbe87c5) texture_cache: detiler: m8x1 and m8x4 shaders - [`1999442`](https://github.com/shadps4-emu/shadPS4/commit/19994424c503d8e6869c53c1bfa0ea8851257e75) texture_cache: detiler: shader module release and debug name - [`0b63a76`](https://github.com/shadps4-emu/shadPS4/commit/0b63a76b518c6959d6ea5175e4938a86bff5ac3d) amdgpu: render target size hint for old runtime ### 📊 Changes **22 files changed** (+612 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+7 -0) 📝 `src/core/libraries/gnmdriver/gnmdriver.cpp` (+1 -1) 📝 `src/video_core/amdgpu/liverpool.cpp` (+1 -1) 📝 `src/video_core/amdgpu/liverpool.h` (+21 -2) 📝 `src/video_core/amdgpu/pixel_format.cpp` (+17 -4) 📝 `src/video_core/amdgpu/pixel_format.h` (+2 -1) 📝 `src/video_core/amdgpu/resource.h` (+20 -1) ➕ `src/video_core/host_shaders/CMakeLists.txt` (+42 -0) ➕ `src/video_core/host_shaders/StringShaderHeader.cmake` (+36 -0) ➕ `src/video_core/host_shaders/detile_m8x1.comp` (+48 -0) ➕ `src/video_core/host_shaders/detile_m8x4.comp` (+57 -0) ➕ `src/video_core/host_shaders/source_shader.h.in` (+14 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+0 -8) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+0 -6) 📝 `src/video_core/texture_cache/image.cpp` (+30 -9) 📝 `src/video_core/texture_cache/image.h` (+6 -0) 📝 `src/video_core/texture_cache/image_view.cpp` (+8 -2) 📝 `src/video_core/texture_cache/image_view.h` (+5 -2) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+56 -54) 📝 `src/video_core/texture_cache/texture_cache.h` (+9 -5) _...and 2 more files_ </details> ### 📄 Description This PR adds a simple detiler for 2D textures (1 and 4 channels only by now) as well as small bug fixes here and there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>