[PR #87] [MERGED] submodules fixes #1278

New issue

Closed

opened 2026-02-27 21:11:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:11:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/87
Author: @georgemoralis
Created: 2/27/2024
Status: ✅ Merged
Merged: 2/27/2024
Merged by: @georgemoralis

Base: main ← Head: discordfixes

📝 Commits (3)

6cfc5f1 update discord-rpc
8a076dd ignore gitmodules on reuse
63ba867 imgui not used atm removed

📊 Changes

10 files changed (+22 additions, -158 deletions)

View changed files

📝 .gitmodules (+4 -10)
📝 .reuse/dep5 (+1 -0)
📝 CMakeLists.txt (+2 -3)
➕ externals/CMakeLists.txt (+14 -0)
➕ externals/discord-rpc (+1 -0)
➖ src/GUI/ElfViewer.cpp (+0 -100)
➖ src/GUI/ElfViewer.h (+0 -18)
📝 third-party/CMakeLists.txt (+0 -25)
➖ third-party/discord-rpc (+0 -1)
➖ third-party/imgui (+0 -1)

📄 Description

-added our own version of discord-rpc , main is quite old and unmaintanced so some fixes might need
-removed imgui , we will add it again if needed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/87 **Author:** [@georgemoralis](https://github.com/georgemoralis) **Created:** 2/27/2024 **Status:** ✅ Merged **Merged:** 2/27/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `discordfixes` --- ### 📝 Commits (3) - [`6cfc5f1`](https://github.com/shadps4-emu/shadPS4/commit/6cfc5f16d522a613a4b0b6791bc5dbd8d0d032ee) update discord-rpc - [`8a076dd`](https://github.com/shadps4-emu/shadPS4/commit/8a076ddc5c36c8bab1e52e614f706c71866b2ec8) ignore gitmodules on reuse - [`63ba867`](https://github.com/shadps4-emu/shadPS4/commit/63ba867902804f7b5f591eb73a92403c7f551c54) imgui not used atm removed ### 📊 Changes **10 files changed** (+22 additions, -158 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+4 -10) 📝 `.reuse/dep5` (+1 -0) 📝 `CMakeLists.txt` (+2 -3) ➕ `externals/CMakeLists.txt` (+14 -0) ➕ `externals/discord-rpc` (+1 -0) ➖ `src/GUI/ElfViewer.cpp` (+0 -100) ➖ `src/GUI/ElfViewer.h` (+0 -18) 📝 `third-party/CMakeLists.txt` (+0 -25) ➖ `third-party/discord-rpc` (+0 -1) ➖ `third-party/imgui` (+0 -1) </details> ### 📄 Description -added our own version of discord-rpc , main is quite old and unmaintanced so some fixes might need -removed imgui , we will add it again if needed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>