[PR #68] [MERGED] cmake: Refactor third party library management #1260

New issue

Closed

opened 2026-02-27 21:11:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:11:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/68
Author: @raphaelthegreat
Created: 11/5/2023
Status: ✅ Merged
Merged: 11/5/2023
Merged by: @georgemoralis

Base: main ← Head: main

📝 Commits (7)

6e28ac7 cmake: Refactor library management
17aefc1 src: Move certain headers in common
a0b8089 cmake: Update CMakeLists.txt
996aa9d cmake: Add include directory to winpthread
303f086 common: Move classes to common namespace
1cf032e cmake: Add directory groups
7bccfeb emulator: Use fmt::format instead of snprintf

📊 Changes

83 files changed (+549 additions, -523 deletions)

View changed files

📝 CMakeLists.txt (+80 -38)
📝 src/Emulator/Host/controller.h (+1 -1)
📝 src/Lib/Timer.h (+1 -1)
➖ src/Util/Disassembler.cpp (+0 -35)
➖ src/Util/Disassembler.h (+0 -17)
📝 src/Util/config.cpp (+1 -1)
📝 src/Util/config.h (+2 -2)
➖ src/Util/log.cpp (+0 -90)
➖ src/Util/log.h (+0 -73)
➖ src/Util/string_util.cpp (+0 -24)
➖ src/Util/string_util.h (+0 -9)
📝 src/common/debug.h (+3 -1)
➕ src/common/disassembler.cpp (+33 -0)
➕ src/common/disassembler.h (+21 -0)
📝 src/common/discord.cpp (+0 -0)
📝 src/common/discord.h (+1 -1)
📝 src/common/fs_file.cpp (+1 -1)
📝 src/common/fs_file.h (+1 -1)
➕ src/common/log.cpp (+114 -0)
➕ src/common/log.h (+33 -0)

...and 63 more files

📄 Description

Remove global include directories in favour of linking to the specific targets when needed
Only link windpthreads and mincore on windows platforms
Add EXCLUDE_FROM_ALL
Move utility headers to new common directory

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/68 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 11/5/2023 **Status:** ✅ Merged **Merged:** 11/5/2023 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (7) - [`6e28ac7`](https://github.com/shadps4-emu/shadPS4/commit/6e28ac711f034a2ecdc8942b064cfcc2c8ad30fc) cmake: Refactor library management - [`17aefc1`](https://github.com/shadps4-emu/shadPS4/commit/17aefc1aefe8f43468df919a625d781adbb09570) src: Move certain headers in common - [`a0b8089`](https://github.com/shadps4-emu/shadPS4/commit/a0b80893db6f5ef22b30987144057a6c842cfb69) cmake: Update CMakeLists.txt - [`996aa9d`](https://github.com/shadps4-emu/shadPS4/commit/996aa9d17a3ca86d46c37e73bd8a2af630c7d578) cmake: Add include directory to winpthread - [`303f086`](https://github.com/shadps4-emu/shadPS4/commit/303f086b1495d3bb97fd380b7c71fc825ac61d59) common: Move classes to common namespace - [`1cf032e`](https://github.com/shadps4-emu/shadPS4/commit/1cf032eeb163975d8ee1a61aaf9ed1cb71006c4b) cmake: Add directory groups - [`7bccfeb`](https://github.com/shadps4-emu/shadPS4/commit/7bccfeb8cc9a5d3397d021d82e1a96ec1bedf55f) emulator: Use fmt::format instead of snprintf ### 📊 Changes **83 files changed** (+549 additions, -523 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+80 -38) 📝 `src/Emulator/Host/controller.h` (+1 -1) 📝 `src/Lib/Timer.h` (+1 -1) ➖ `src/Util/Disassembler.cpp` (+0 -35) ➖ `src/Util/Disassembler.h` (+0 -17) 📝 `src/Util/config.cpp` (+1 -1) 📝 `src/Util/config.h` (+2 -2) ➖ `src/Util/log.cpp` (+0 -90) ➖ `src/Util/log.h` (+0 -73) ➖ `src/Util/string_util.cpp` (+0 -24) ➖ `src/Util/string_util.h` (+0 -9) 📝 `src/common/debug.h` (+3 -1) ➕ `src/common/disassembler.cpp` (+33 -0) ➕ `src/common/disassembler.h` (+21 -0) 📝 `src/common/discord.cpp` (+0 -0) 📝 `src/common/discord.h` (+1 -1) 📝 `src/common/fs_file.cpp` (+1 -1) 📝 `src/common/fs_file.h` (+1 -1) ➕ `src/common/log.cpp` (+114 -0) ➕ `src/common/log.h` (+33 -0) _...and 63 more files_ </details> ### 📄 Description * Remove global include directories in favour of linking to the specific targets when needed * Only link windpthreads and mincore on windows platforms * Add EXCLUDE_FROM_ALL * Move utility headers to new common directory --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>