[PR #10] [MERGED] Remove shortest and fix audio cutting bug #12

New issue

Closed

opened 2026-03-01 14:33:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 14:33:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/adefossez/seewav/pull/10
Author: @ShaneLee
Created: 12/8/2023
Status: ✅ Merged
Merged: 12/8/2023
Merged by: @adefossez

Base: master ← Head: bugfix/cut-audio

📝 Commits (1)

d2a0423 Remove shortest and fix audio cutting bug

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 seewav.py (+1 -1)

📄 Description

Relates to issue #8

Context:

The -shortest flag in FFmpeg is used to specify that only the shortest input file should be used when concatenating multiple input files. This is useful when you want to combine multiple audio or video clips into a single file, but you don't want to include any clips that are longer than the others.

In this particular case we are creating the video from the audio so using-shortest doesn't make sense as they are both the exact same length.

There are two ways that I am aware of this bug manifests itself. One is as described in #8 where the audio cuts out towards the end of the clip. The other way is when you specify a short duration (1-3 seconds) that will lead to no audio at all from my testing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adefossez/seewav/pull/10 **Author:** [@ShaneLee](https://github.com/ShaneLee) **Created:** 12/8/2023 **Status:** ✅ Merged **Merged:** 12/8/2023 **Merged by:** [@adefossez](https://github.com/adefossez) **Base:** `master` ← **Head:** `bugfix/cut-audio` --- ### 📝 Commits (1) - [`d2a0423`](https://github.com/adefossez/seewav/commit/d2a0423d4d828adb18f6f073e872940eca78609d) Remove shortest and fix audio cutting bug ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `seewav.py` (+1 -1) </details> ### 📄 Description Relates to issue #8 Context: The -shortest flag in FFmpeg is used to specify that only the shortest input file should be used when concatenating multiple input files. This is useful when you want to combine multiple audio or video clips into a single file, but you don't want to include any clips that are longer than the others. In this particular case we are creating the video from the audio so using`-shortest` doesn't make sense as they are both the exact same length. There are two ways that I am aware of this bug manifests itself. One is as described in #8 where the audio cuts out towards the end of the clip. The other way is when you specify a short duration (1-3 seconds) that will lead to no audio at all from my testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>