starred/scramble
1
0
Fork 0
mirror of https://github.com/zlwaterfield/scramble.git synced 2026-04-27 00:16:00 +03:00
Code Issues 4 Projects Releases Packages Wiki Activity

[PR #7] [CLOSED] [WIP] Firefox support #13

New issue
Closed
opened 2026-03-04 02:09:38 +03:00 by kerem · 0 comments
kerem commented 2026-03-04 02:09:38 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/zlwaterfield/scramble/pull/7
Author: @len-foss
Created: 9/18/2024
Status: ❌ Closed

Base: main ← Head: firefox

📝 Commits (4)

📊 Changes

5 files changed (+52 additions, -8 deletions)

View changed files

📝 background.js (+9 -3)
📝 content.js (+19 -1)
📝 manifest.json (+10 -2)
📝 options.html (+8 -0)
📝 options.js (+6 -2)

📄 Description

A very quick and dirty pass to make it work on Firefox. Would require more testing.

It seem the selection range won't work with text inputs on FF, so I quickly hacked a way around it.

Note: this is based on the extended support branch, but does really depend on it.

Would close #2

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/zlwaterfield/scramble/pull/7 **Author:** [@len-foss](https://github.com/len-foss) **Created:** 9/18/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `firefox` --- ### 📝 Commits (4) - [`db8e851`](https://github.com/zlwaterfield/scramble/commit/db8e851f0d12303708869297084c07897b40125e) *ENDPOINTS - [`d4cf9d8`](https://github.com/zlwaterfield/scramble/commit/d4cf9d8bad378a4ca081428000a4fd8a934e5afc) manifest permissions - [`a249f52`](https://github.com/zlwaterfield/scramble/commit/a249f524e7e0890a87b2f38ecac1f181329647e2) *FF manifest - [`7a03db2`](https://github.com/zlwaterfield/scramble/commit/7a03db2423659a11f89886d6b45ec5c4b0a8f0fc) WIP firefox ### 📊 Changes **5 files changed** (+52 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `background.js` (+9 -3) 📝 `content.js` (+19 -1) 📝 `manifest.json` (+10 -2) 📝 `options.html` (+8 -0) 📝 `options.js` (+6 -2) </details> ### 📄 Description A very quick and dirty pass to make it work on Firefox. Would require more testing. It seem the selection range won't work with text inputs on FF, so I quickly hacked a way around it. Note: this is based on the extended support branch, but does really depend on it. Would close #2 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:09:38 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
suggestions
No results found.
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/scramble#13
No description provided.