[PR #2] [CLOSED] Logical statement on line 57 of sandman2/__init__.py, replaced 'if' with... #93

Closed
opened 2026-02-26 01:33:12 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jeffknupp/sandman2/pull/2
Author: @jessebraham
Created: 12/2/2014
Status: Closed

Base: masterHead: master


📝 Commits (1)

  • b134bd9 Logical statement on line 57 of sandman2/init.py, replaced 'if' with 'elif'. sandman_model returned to line 150 of the same file. These changes make all tests pass.

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 sandman2/__init__.py (+3 -2)

📄 Description

Logical error on line 57 of sandman2/__init__.py, replaced if with elif.

sandman_model returned to line 150 of sandman2/__init__.py. Line 151 updated accordingly. Not sure what the reason for changing this was previously.

I feel a tad silly making a pull request for such a small contribution. However, upon finding this project both TravisCI and myself agreed that the tests weren't passing. These changes make all tests pass for me.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jeffknupp/sandman2/pull/2 **Author:** [@jessebraham](https://github.com/jessebraham) **Created:** 12/2/2014 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`b134bd9`](https://github.com/jeffknupp/sandman2/commit/b134bd9d5ac5aee7d9f046570529845a27da7378) Logical statement on line 57 of sandman2/__init__.py, replaced 'if' with 'elif'. sandman_model returned to line 150 of the same file. These changes make all tests pass. ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `sandman2/__init__.py` (+3 -2) </details> ### 📄 Description Logical error on _line 57_ of `sandman2/__init__.py`, replaced `if` with `elif`. `sandman_model` returned to _line 150_ of `sandman2/__init__.py`. _Line 151_ updated accordingly. Not sure what the reason for changing this was previously. I feel a tad silly making a pull request for such a small contribution. However, upon finding this project both TravisCI and myself agreed that the tests weren't passing. These changes make all tests pass for me. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 01:33:12 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/sandman2-jeffknupp#93
No description provided.