mirror of
https://github.com/jeffknupp/sandman2.git
synced 2026-04-25 00:25:49 +03:00
[GH-ISSUE #75] Distribute as docker images #50
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
pull-request
question
refactoring
research
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/sandman2-jeffknupp#50
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pscanf on GitHub (Oct 22, 2018).
Original GitHub issue: https://github.com/jeffknupp/sandman2/issues/75
Last year I started using sandman2 at my company for building a quick admin console. Since we use docker to deploy things, and since the project doesn't provide official docker images, I dockerized it myself and published the image on docker hub.
The image (which only targets mssql) has since been downloaded 100k+ times, probably because it's the first result when searching for sandman on docker hub.
A couple of days ago I received a PR on the docker image repo to update some dependencies, but I'm hesitant to merge it to master because the update could potentially break existing users (back when I created the image I didn't think about setting up a versioning scheme for it, so everything that goes into the master branch of the repo gets published as the
latesttag of the docker image).So to get to the point, since there appears to be some demand for a dockerized version of sandman2, you might want to consider directly publishing images for it.
@jeffknupp commented on GitHub (Oct 23, 2018):
Will do. Thanks so much for the head's up. I'll update this issue when official image is out.
@jeffknupp commented on GitHub (Oct 26, 2018):
@pscanf could you post the contents of
start.shhere? I'll re-use it if applicable@pscanf commented on GitHub (Oct 26, 2018):
You can find it in the repo from which the image builds: https://github.com/mondora/docker-sandman2-mssql/blob/master/start.sh