[PR #99] [MERGED] Enable encoding for the read function. #135

New issue

Closed

opened 2026-02-26 01:33:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 01:33:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jeffknupp/sandman2/pull/99
Author: @Expire0
Created: 5/12/2019
Status: ✅ Merged
Merged: 5/29/2019
Merged by: @jeffknupp

Base: master ← Head: master

📝 Commits (2)

a7f0e34 Update setup.py
27d16b1 Update setup.py

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 setup.py (+2 -2)

📄 Description

The encoding is needed or installation will fail for Python3. I tested this change locally and it works with the encoding.

Traceback (most recent call last):
File "setup.py", line 19, in
LONG_DESCRIPTION = read('README.rst')
File "setup.py", line 17, in read
return codecs.open(os.path.join(HERE, *parts), 'r').read()
File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 563: ordinal not in range(128)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jeffknupp/sandman2/pull/99 **Author:** [@Expire0](https://github.com/Expire0) **Created:** 5/12/2019 **Status:** ✅ Merged **Merged:** 5/29/2019 **Merged by:** [@jeffknupp](https://github.com/jeffknupp) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`a7f0e34`](https://github.com/jeffknupp/sandman2/commit/a7f0e34e4692e09639b92d1902b8dacb92ccf443) Update setup.py - [`27d16b1`](https://github.com/jeffknupp/sandman2/commit/27d16b12a015d638ce776384f4e4eea70f881a9c) Update setup.py ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `setup.py` (+2 -2) </details> ### 📄 Description The encoding is needed or installation will fail for Python3. I tested this change locally and it works with the encoding. Traceback (most recent call last): File "setup.py", line 19, in <module> LONG_DESCRIPTION = read('README.rst') File "setup.py", line 17, in read return codecs.open(os.path.join(HERE, *parts), 'r').read() File "/usr/lib/python3.5/encodings/ascii.py", line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 563: ordinal not in range(128) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>