[PR #35] [MERGED] Return key in Model.primary_key() #107

New issue

Closed

opened 2026-02-26 01:33:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 01:33:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jeffknupp/sandman2/pull/35
Author: @hroncok
Created: 4/25/2016
Status: ✅ Merged
Merged: 7/22/2016
Merged by: @jeffknupp

Base: master ← Head: patch-1

📝 Commits (1)

c0f0b19 Return key in Model.primary_key()

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 sandman2/model.py (+2 -2)

📄 Description

If the column has different name than key, we need key, otherwise it doesn't work.
Consider the following column:

id_teacher = db.Column('id_lector', db.Integer, primary_key=True, key='id_teacher')

Name gets id_lector, key gets id_teacher. With name, we get (form resouce_uri()):

AttributeError: 'Teachers' object has no attribute 'id_lector'

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jeffknupp/sandman2/pull/35 **Author:** [@hroncok](https://github.com/hroncok) **Created:** 4/25/2016 **Status:** ✅ Merged **Merged:** 7/22/2016 **Merged by:** [@jeffknupp](https://github.com/jeffknupp) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`c0f0b19`](https://github.com/jeffknupp/sandman2/commit/c0f0b197d926015c4966274be9b5a44a53eb364b) Return key in Model.primary_key() ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `sandman2/model.py` (+2 -2) </details> ### 📄 Description If the column has different name than key, we need key, otherwise it doesn't work. Consider the following column: ``` id_teacher = db.Column('id_lector', db.Integer, primary_key=True, key='id_teacher') ``` Name gets `id_lector`, key gets `id_teacher`. With name, we get (form `resouce_uri()`): ``` AttributeError: 'Teachers' object has no attribute 'id_lector' ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>