[GH-ISSUE #1854] Check return value from close #944

New issue

Open

opened 2026-03-04 01:50:07 +03:00 by kerem · 1 comment

kerem commented

2026-03-04 01:50:07 +03:00

Owner

Originally created by @gaul on GitHub (Jan 12, 2022).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1854

close(2) and fclose(3) can return errors in some exceptional situations but s3fs never checks this. There is not much we can do other than log and propagate, however.

Originally created by @gaul on GitHub (Jan 12, 2022). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1854 `close(2)` and `fclose(3)` can return errors in some exceptional situations but s3fs never checks this. There is not much we can do other than log and propagate, however.

kerem commented

2026-03-04 01:50:08 +03:00

Author

Owner

@ggtakec commented on GitHub (Jan 22, 2022):

For a long time, even in a general program, the error from close() is difficult to handle.
The only thing we can do inside s3fs may be to log it, as you say.
Or s3fs retry again to close with limit the number of times
I think, even if we can handle this error, it will be difficult to deal with it.

@ggtakec commented on GitHub (Jan 22, 2022): For a long time, even in a general program, the error from close() is difficult to handle. The only thing we can do inside s3fs may be to log it, as you say. Or s3fs retry again to close with limit the number of times I think, even if we can handle this error, it will be difficult to deal with it.