[GH-ISSUE #1843] Change shell script assignments to locals #940

New issue

Closed

opened 2026-03-04 01:50:06 +03:00 by kerem · 1 comment

kerem commented

2026-03-04 01:50:06 +03:00

Owner

Originally created by @gaul on GitHub (Jan 7, 2022).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1843

Most of the test shell script functions assign to the global namespace. These should instead annotate their variables as local. A naming collision confused me in #1841.

Originally created by @gaul on GitHub (Jan 7, 2022). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1843 Most of the test shell script functions assign to the global namespace. These should instead annotate their variables as `local`. A naming collision confused me in #1841.

kerem closed this issue

2026-03-04 01:50:06 +03:00

kerem commented

2026-03-04 01:50:07 +03:00

Author

Owner

@ggtakec commented on GitHub (Jan 9, 2022):

There is no objection to adding local to local variables.
(I was confused many times, too)
Thanks for your #1844 PR.

@ggtakec commented on GitHub (Jan 9, 2022): There is no objection to adding `local` to local variables. (I was confused many times, too) Thanks for your #1844 PR.

kerem referenced this issue

2026-03-04 02:01:48 +03:00

[PR #940] [MERGED] Copy parts in parallel #1714