mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 13:26:00 +03:00
[GH-ISSUE #1825] Audit partial writes #937
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#937
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gaul on GitHub (Jan 2, 2022).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1825
Most of our code calls
pwriteand checks != -1. There are some corner cases with signals and disk full that can cause partial writes. We should add a helper function which restarts the write with the partial buffer. It would also be nice to write anLD_PRELOADhelper which simulates these short writes.@ggtakec commented on GitHub (Jan 9, 2022):
I think it is easy to implement the retry processing of interruption by signal.
And recovering Disk full seems to be difficult because I think that an error will occur again even if trying again.(Because we have to make free disk space, ...)