[GH-ISSUE #1662] Look at GCS-specific headers #870

New issue

Closed

opened 2026-03-04 01:49:31 +03:00 by kerem · 4 comments

kerem commented

2026-03-04 01:49:31 +03:00

Owner

Originally created by @gaul on GitHub (May 20, 2021).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1662

s3fs should have a GCS mode which uses headers like x-goog-storage-class instead of x-amz-storage-class:

https://cloud.google.com/storage/docs/xml-api/reference-headers#xgoogstorageclass

Related to #1613.

Originally created by @gaul on GitHub (May 20, 2021). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1662 s3fs should have a GCS mode which uses headers like `x-goog-storage-class` instead of `x-amz-storage-class`: https://cloud.google.com/storage/docs/xml-api/reference-headers#xgoogstorageclass Related to #1613.

kerem closed this issue

2026-03-04 01:49:32 +03:00

kerem commented

2026-03-04 01:49:32 +03:00

Author

Owner

@ggtakec commented on GitHub (May 20, 2021):

@gaul Should we switch to use x-goog-meta-* and x-amz-meta* properly?

@ggtakec commented on GitHub (May 20, 2021): @gaul Should we switch to use `x-goog-meta-*` and `x-amz-meta*` properly?

kerem commented

2026-03-04 01:49:32 +03:00

Author

Owner

@gaul commented on GitHub (May 20, 2021):

I think we might want to add a --gcs flag or automatically change to GCS mode based on --url matching storage.googleapis.com.

@gaul commented on GitHub (May 20, 2021): I think we might want to add a `--gcs` flag or automatically change to GCS mode based on `--url` matching storage.googleapis.com.

kerem commented

2026-03-04 01:49:33 +03:00

Author

Owner

@ggtakec commented on GitHub (May 20, 2021):

Both look good. However, considering that there may be such differences in other parts in the future, I think the --gcs option seems to be better.

@ggtakec commented on GitHub (May 20, 2021): Both look good. However, considering that there may be such differences in other parts in the future, I think the `--gcs` option seems to be better.

kerem commented

2026-03-04 01:49:33 +03:00

Author

Owner

@gaul commented on GitHub (May 22, 2021):

This bug may be invalid. GCS supports x-amz-storage-class and it doesn't appear that the other headers provide any value, except for conditional PUT. I think there are some other ETag sanity checks that we should do before looking at vendor-specific conditional PUT though.

@gaul commented on GitHub (May 22, 2021): This bug may be invalid. GCS supports `x-amz-storage-class` and it doesn't appear that the other headers provide any value, except for conditional PUT. I think there are some other ETag sanity checks that we should do before looking at vendor-specific conditional PUT though.

kerem referenced this issue

2026-03-04 02:01:35 +03:00

[PR #870] [MERGED] Correct typos in command-line parsing #1670