starred/s3fs-fuse

Fork 0

mirror of https://github.com/s3fs-fuse/s3fs-fuse.git synced 2026-04-25 21:35:58 +03:00

[GH-ISSUE #145] rename_before_close failure #87

New issue

Closed

opened 2026-03-04 01:41:54 +03:00 by kerem · 10 comments

kerem commented

2026-03-04 01:41:54 +03:00

Owner

Originally created by @gaul on GitHub (Mar 9, 2015).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/145

$ make check -C test
...
rename_before_close: rename_before_close.c:46: test_rename_before_close: Assertion `get_file_size(template) == sizeof(FILE_CONTENT)' failed.
./integration-test-main.sh: line 274: 18749 Aborted                 (core dumped) $CUR_DIR/rename_before_close $TEST_TEXT_FILE

@kahing Can you investigate?

Originally created by @gaul on GitHub (Mar 9, 2015). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/145 ``` $ make check -C test ... rename_before_close: rename_before_close.c:46: test_rename_before_close: Assertion `get_file_size(template) == sizeof(FILE_CONTENT)' failed. ./integration-test-main.sh: line 274: 18749 Aborted (core dumped) $CUR_DIR/rename_before_close $TEST_TEXT_FILE ``` @kahing Can you investigate?

kerem closed this issue

2026-03-04 01:41:54 +03:00

kerem commented

2026-03-04 01:41:55 +03:00

Author

Owner

@gaul commented on GitHub (Mar 9, 2015):

Note that I tested with s3proxy-1.4.0-20150307.195914-6-jar-with-dependencies.jar, not 1.3.0 release.

@gaul commented on GitHub (Mar 9, 2015): Note that I tested with s3proxy-1.4.0-20150307.195914-6-jar-with-dependencies.jar, not 1.3.0 release.

kerem commented

2026-03-04 01:41:55 +03:00

Author

Owner

@kahing commented on GitHub (Mar 9, 2015):

I got failure before it gets to that test:

Testing mv file function ...
moved file length is not as expected expected: 12  got: 0

Looking...

@kahing commented on GitHub (Mar 9, 2015): I got failure before it gets to that test: ``` Testing mv file function ... moved file length is not as expected expected: 12 got: 0 ``` Looking...

kerem commented

2026-03-04 01:41:55 +03:00

Author

Owner

@gaul commented on GitHub (Mar 9, 2015):

Sorry we need to merge #147 to avoid the first set of failures.

@gaul commented on GitHub (Mar 9, 2015): Sorry we need to merge #147 to avoid the first set of failures.

kerem commented

2026-03-04 01:41:55 +03:00

Author

Owner

@kahing commented on GitHub (Mar 9, 2015):

confirmed that #147 fixes the first rename problem. confirmed that the rename_before_close test fails with real S3 as well

@kahing commented on GitHub (Mar 9, 2015): confirmed that #147 fixes the first rename problem. confirmed that the rename_before_close test fails with real S3 as well

kerem commented

2026-03-04 01:41:55 +03:00

Author

Owner

@kahing commented on GitHub (Mar 9, 2015):

regression caused by #138. Reverting the no_cache prefix changes fixes this problem.

I am not sure what the no_cache prefix change is intended to fix, why wouldn't we always want to use the same FdEntity?

@kahing commented on GitHub (Mar 9, 2015): regression caused by #138. Reverting the no_cache prefix changes fixes this problem. I am not sure what the no_cache prefix change is intended to fix, why wouldn't we always want to use the same FdEntity?

kerem commented

2026-03-04 01:41:55 +03:00

Author

Owner

@ggtakec commented on GitHub (Mar 10, 2015):

@kahing I meged fixed code to master branch now.
This problem is occurred by s3fs does not have fsync handler. so fsync event could not be caught by s3fs.
Before #138, s3fs could not disable the use_cache, in order to have continued to share the file handle, had happened fsync functions. After fixing #138, poblem of this issue was apparent.
Probably #150 fixed this issue.

@andrewgaul @kahing thanks a lot.

if this merge can fix all of this issue, please close this issue.
Regards,

@ggtakec commented on GitHub (Mar 10, 2015): @kahing I meged fixed code to master branch now. This problem is occurred by s3fs does not have fsync handler. so fsync event could not be caught by s3fs. Before #138, s3fs could not disable the use_cache, in order to have continued to share the file handle, had happened fsync functions. After fixing #138, poblem of this issue was apparent. Probably #150 fixed this issue. @andrewgaul @kahing thanks a lot. if this merge can fix all of this issue, please close this issue. Regards,

kerem commented

2026-03-04 01:41:55 +03:00

Author

Owner

@ggtakec commented on GitHub (Mar 21, 2015):

I close this issue.
If you continue to not solve this problem, please reopen this issue.
Thanks a lot.

@ggtakec commented on GitHub (Mar 21, 2015): I close this issue. If you continue to not solve this problem, please reopen this issue. Thanks a lot.

kerem commented

2026-03-04 01:41:55 +03:00

Author

Owner

@kahing commented on GitHub (Apr 9, 2015):

master still fails the rename_before_close test

@kahing commented on GitHub (Apr 9, 2015): master still fails the rename_before_close test

kerem commented

2026-03-04 01:41:56 +03:00

Author

Owner

@gaul commented on GitHub (Apr 24, 2015):