[GH-ISSUE #1658] Increase test robustness by adding LC_ALL=C #866

Closed
opened 2026-03-04 01:49:30 +03:00 by kerem · 1 comment
Owner

Originally created by @CarstenGrohmann on GitHub (May 17, 2021).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1658

Some test cases check the output of commands for English expressions. This may cause the test suite to fail for users with non-English locale settings.

I suggest to add LC_ALL=C at the beginning of test_utils.sh to address this problem.

I would open a PR, if you agree with this solution.

Originally created by @CarstenGrohmann on GitHub (May 17, 2021). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1658 Some test cases check the output of commands for English expressions. This may cause the test suite to fail for users with non-English locale settings. I suggest to add `LC_ALL=C` at the beginning of `test_utils.sh` to address this problem. I would open a PR, if you agree with this solution.
kerem closed this issue 2026-03-04 01:49:30 +03:00
Author
Owner

@gaul commented on GitHub (May 19, 2021):

This makes sense. Over the longer term hopefully we can move to finer-grainer errno handling, either via pjdfstests.c or Python unit tests.

<!-- gh-comment-id:844035374 --> @gaul commented on GitHub (May 19, 2021): This makes sense. Over the longer term hopefully we can move to finer-grainer errno handling, either via `pjdfstests.c` or Python unit tests.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#866
No description provided.