[GH-ISSUE #1289] curldbg should log some request and response bodies #691

New issue

Closed

opened 2026-03-04 01:47:55 +03:00 by kerem · 2 comments

kerem commented

2026-03-04 01:47:55 +03:00

Owner

Originally created by @gaul on GitHub (May 14, 2020).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1289

It would be helped to log the request bodies for calls like CompleteMultipartUpload and the response bodies for calls like ListObjects.

Originally created by @gaul on GitHub (May 14, 2020). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1289 It would be helped to log the request bodies for calls like `CompleteMultipartUpload` and the response bodies for calls like `ListObjects`.

kerem closed this issue

2026-03-04 01:47:55 +03:00

kerem commented

2026-03-04 01:47:56 +03:00

Author

Owner

@ggtakec commented on GitHub (May 14, 2020):

@gaul I also agree with your opinion.

I think there are two ways to do that.
One is to implement CURLOPT_DEBUGFUNCTION to enable fine control.
The other is to output bodies as a debug message only for CompleteMultipartUpload and ListObjects.

I think that implementing the DEBUG FUNCTION will take some effort. Thus I think the second option is better.

In any case, I think we also need to upgreade the curldbg option.
If always dumping the body will make the debug log bigger than current.
Therefore, I think it seems better to divide the curl debug information into the current level and the level at which body is dumped.

For example, we prepare for three types curldbg: curldbg(no parameter: same as the current), curldbg=normal(same as no parameter for curldbg), curldbg=deep(with dumping bodies).
It means that new curldbg option can have a parameters(optional).

If there is no problem with this idea, I will make a PR for this issue.

@ggtakec commented on GitHub (May 14, 2020): @gaul I also agree with your opinion. I think there are two ways to do that. One is to implement `CURLOPT_DEBUGFUNCTION` to enable fine control. The other is to output bodies as a debug message only for `CompleteMultipartUpload` and `ListObjects`. I think that implementing the `DEBUG FUNCTION` will take some effort. Thus I think the second option is better. In any case, I think we also need to upgreade the curldbg option. If always dumping the body will make the debug log bigger than current. Therefore, I think it seems better to divide the curl debug information into the current level and the level at which body is dumped. For example, we prepare for three types curldbg: `curldbg`(no parameter: same as the current), `curldbg=normal`(same as no parameter for curldbg), `curldbg=deep`(with dumping bodies). It means that new curldbg option can have a parameters(optional). If there is no problem with this idea, I will make a PR for this issue.

kerem commented

2026-03-04 01:47:56 +03:00

Author

Owner

@ggtakec commented on GitHub (May 25, 2020):

Close this Issue.
If the problem remains, please reopen.

@ggtakec commented on GitHub (May 25, 2020): Close this Issue. If the problem remains, please reopen.

kerem referenced this issue

2026-03-04 02:01:30 +03:00

[PR #819] [MERGED] #691: Made instructions for creating password file more obvious. #1650