mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 05:16:00 +03:00
[GH-ISSUE #1184] prepare_url screws up the uri if the bucket name and endpoint prefix match #625
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#625
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bryceml on GitHub (Oct 26, 2019).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1184
Additional Information
Version of s3fs being used (s3fs --version)
Amazon Simple Storage Service File System V1.84(commit:unknown) with GnuTLS(gcrypt)
Copyright (C) 2010 Randy Rizun rrizun@gmail.com
License GPL2: GNU GPL version 2 http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Version of fuse being used (pkg-config --modversion fuse, rpm -qi fuse, dpkg -s fuse)
Version: 2.9.9-1ubuntu1
Kernel information (uname -r)
5.3.0-19-generic
GNU/Linux Distribution, if applicable (cat /etc/os-release)
Ubuntu19.10
s3fs command line used, if applicable
/etc/fstab entry, if applicable
s3fs syslog messages (grep s3fs /var/log/syslog, journalctl | grep s3fs, or s3fs outputs)
Details about issue
What I can determine from the issue, is that if the beginning of the url before the first period matches the bucket name, it screws up calculating the bucket.
What works:
s3fs -f /tmp/test -o url=http://dezb4fersljmf.cloudfront.net -o use_path_request_style -o public_bucket=1 -o bucket=s3
If I do a wireshark packet capture, I see it is checking /s3/ as the uri
What doesn't work:
s3fs -f /tmp/test -o url=http://s3.repo.saltstack.com -o use_path_request_style -o public_bucket=1 -o bucket=s3
If I do a wireshark packet capture, I see it is trying to fetch /s3//s3/.repo.saltstack.com/s3/
I re-ran it with debug level info and got the following:
Here is the output of the info log when the host name doesn't match:
@bryceml commented on GitHub (Nov 5, 2019):
This can probably be closed if the change is well tested.