[GH-ISSUE #1157] Build error by cppcheck 1.89 #604

New issue

Closed

opened 2026-03-04 01:47:08 +03:00 by kerem · 1 comment

kerem commented

2026-03-04 01:47:08 +03:00

Owner

Originally created by @ggtakec on GitHub (Sep 23, 2019).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1157

Version of s3fs being used (s3fs --version)

master branch for OSX

Version of fuse being used (pkg-config --modversion fuse, rpm -qi fuse, dpkg -s fuse)

n/a

Kernel information (uname -r)

n/a

GNU/Linux Distribution, if applicable (cat /etc/os-release)

OSX

s3fs command line used, if applicable

make cppcheck is failed in build-step.

/etc/fstab entry, if applicable

n/a

s3fs syslog messages (grep s3fs /var/log/syslog, journalctl | grep s3fs, or s3fs outputs)

run make cppcheck, we got following error on OSX.

<error id="invalidContainer" severity="error" msg="Using iterator to local container &apos;addheadlist&apos; that may be invalid." verbose="Using iterator to local container &apos;addheadlist&apos; that may be invalid." cwe="664">
    <location file="src/addhead.cpp" line="172" column="26"/>
    <location file0="src/addhead.cpp" file="src/addhead.h" line="43" column="29" info="Variable created here."/>
    <location file="src/addhead.cpp" line="171" column="93" info="After calling &apos;erase&apos;, iterators or references to the container&apos;s data may be invalid ."/>
    <location file="src/addhead.cpp" line="171" column="38" info="Iterator to container is created here."/>
</error>
<error id="constParameter" severity="style" msg="Parameter &apos;ts1&apos; can be declared with const" verbose="Parameter &apos;ts1&apos; can be declared with const" cwe="398">
    <location file="src/cache.cpp" line="90" column="50"/>
</error>
<error id="constParameter" severity="style" msg="Parameter &apos;ts2&apos; can be declared with const" verbose="Parameter &apos;ts2&apos; can be declared with const" cwe="398">
    <location file="src/cache.cpp" line="90" column="72"/>
</error>
<error id="constParameter" severity="style" msg="Parameter &apos;key&apos; can be declared with const" verbose="Parameter &apos;key&apos; can be declared with const" cwe="398">
    <location file="src/cache.cpp" line="307" column="41"/>
</error>
<error id="constParameter" severity="style" msg="Parameter &apos;upload_id&apos; can be declared with const" verbose="Parameter &apos;upload_id&apos; can be declared with const" cwe="398">
    <location file="src/curl.cpp" line="3453" column="71"/>
</error>
<error id="constParameter" severity="style" msg="Parameter &apos;upload_id&apos; can be declared with const" verbose="Parameter &apos;upload_id&apos; can be declared with const" cwe="398">
    <location file="src/curl.cpp" line="3567" column="63"/>
</error>
<error id="constParameter" severity="style" msg="Parameter &apos;upload_id&apos; can be declared with const" verbose="Parameter &apos;upload_id&apos; can be declared with const" cwe="398">
    <location file="src/curl.cpp" line="3702" column="94"/>
</error>
<error id="knownConditionTrueFalse" severity="style" msg="Condition &apos;result&apos; is always false" verbose="Condition &apos;result&apos; is always false" cwe="570">
    <location file="src/s3fs.cpp" line="2753" column="12" info="Condition &apos;result&apos; is always false"/>
    <location file="src/s3fs.cpp" line="2750" column="17" info="Assignment &apos;result=false&apos;, assigned value is 0"/>
</error>
<error id="knownConditionTrueFalse" severity="style" msg="Condition &apos;result&apos; is always false" verbose="Condition &apos;result&apos; is always false" cwe="570">
    <location file="src/s3fs.cpp" line="2880" column="12" info="Condition &apos;result&apos; is always false"/>
    <location file="src/s3fs.cpp" line="2876" column="17" info="Assignment &apos;result=false&apos;, assigned value is 0"/>
</error>
<error id="constParameter" severity="style" msg="Parameter &apos;head&apos; can be declared with const" verbose="Parameter &apos;head&apos; can be declared with const" cwe="398">
    <location file="src/s3fs.cpp" line="2443" column="60"/>
</error>
<error id="knownConditionTrueFalse" severity="style" msg="Condition &apos;result&apos; is always false" verbose="Condition &apos;result&apos; is always false" cwe="570">
    <location file="src/s3fs_util.cpp" line="997" column="12" info="Condition &apos;result&apos; is always false"/>
    <location file="src/s3fs_util.cpp" line="994" column="17" info="Assignment &apos;result=false&apos;, assigned value is 0"/>
</error>
<error id="knownConditionTrueFalse" severity="style" msg="Condition &apos;result&apos; is always false" verbose="Condition &apos;result&apos; is always false" cwe="570">
    <location file="src/s3fs_util.cpp" line="1003" column="12" info="Condition &apos;result&apos; is always false"/>
    <location file="src/s3fs_util.cpp" line="994" column="17" info="Assignment &apos;result=false&apos;, assigned value is 0"/>
</error>
<error id="knownConditionTrueFalse" severity="style" msg="Condition &apos;result&apos; is always false" verbose="Condition &apos;result&apos; is always false" cwe="570">
    <location file="src/s3fs_util.cpp" line="1008" column="12" info="Condition &apos;result&apos; is always false"/>
    <location file="src/s3fs_util.cpp" line="994" column="17" info="Assignment &apos;result=false&apos;, assigned value is 0"/>
</error>

Details about issue

I will make a patch as soon as possible.

Originally created by @ggtakec on GitHub (Sep 23, 2019). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1157 #### Version of s3fs being used (s3fs --version) master branch for OSX #### Version of fuse being used (pkg-config --modversion fuse, rpm -qi fuse, dpkg -s fuse) n/a #### Kernel information (uname -r) n/a #### GNU/Linux Distribution, if applicable (cat /etc/os-release) OSX #### s3fs command line used, if applicable `make cppcheck` is failed in build-step. #### /etc/fstab entry, if applicable n/a #### s3fs syslog messages (grep s3fs /var/log/syslog, journalctl | grep s3fs, or s3fs outputs) run make cppcheck, we got following error on OSX. ``` <error id="invalidContainer" severity="error" msg="Using iterator to local container 'addheadlist' that may be invalid." verbose="Using iterator to local container 'addheadlist' that may be invalid." cwe="664"> <location file="src/addhead.cpp" line="172" column="26"/> <location file0="src/addhead.cpp" file="src/addhead.h" line="43" column="29" info="Variable created here."/> <location file="src/addhead.cpp" line="171" column="93" info="After calling 'erase', iterators or references to the container's data may be invalid ."/> <location file="src/addhead.cpp" line="171" column="38" info="Iterator to container is created here."/> </error> <error id="constParameter" severity="style" msg="Parameter 'ts1' can be declared with const" verbose="Parameter 'ts1' can be declared with const" cwe="398"> <location file="src/cache.cpp" line="90" column="50"/> </error> <error id="constParameter" severity="style" msg="Parameter 'ts2' can be declared with const" verbose="Parameter 'ts2' can be declared with const" cwe="398"> <location file="src/cache.cpp" line="90" column="72"/> </error> <error id="constParameter" severity="style" msg="Parameter 'key' can be declared with const" verbose="Parameter 'key' can be declared with const" cwe="398"> <location file="src/cache.cpp" line="307" column="41"/> </error> <error id="constParameter" severity="style" msg="Parameter 'upload_id' can be declared with const" verbose="Parameter 'upload_id' can be declared with const" cwe="398"> <location file="src/curl.cpp" line="3453" column="71"/> </error> <error id="constParameter" severity="style" msg="Parameter 'upload_id' can be declared with const" verbose="Parameter 'upload_id' can be declared with const" cwe="398"> <location file="src/curl.cpp" line="3567" column="63"/> </error> <error id="constParameter" severity="style" msg="Parameter 'upload_id' can be declared with const" verbose="Parameter 'upload_id' can be declared with const" cwe="398"> <location file="src/curl.cpp" line="3702" column="94"/> </error> <error id="knownConditionTrueFalse" severity="style" msg="Condition 'result' is always false" verbose="Condition 'result' is always false" cwe="570"> <location file="src/s3fs.cpp" line="2753" column="12" info="Condition 'result' is always false"/> <location file="src/s3fs.cpp" line="2750" column="17" info="Assignment 'result=false', assigned value is 0"/> </error> <error id="knownConditionTrueFalse" severity="style" msg="Condition 'result' is always false" verbose="Condition 'result' is always false" cwe="570"> <location file="src/s3fs.cpp" line="2880" column="12" info="Condition 'result' is always false"/> <location file="src/s3fs.cpp" line="2876" column="17" info="Assignment 'result=false', assigned value is 0"/> </error> <error id="constParameter" severity="style" msg="Parameter 'head' can be declared with const" verbose="Parameter 'head' can be declared with const" cwe="398"> <location file="src/s3fs.cpp" line="2443" column="60"/> </error> <error id="knownConditionTrueFalse" severity="style" msg="Condition 'result' is always false" verbose="Condition 'result' is always false" cwe="570"> <location file="src/s3fs_util.cpp" line="997" column="12" info="Condition 'result' is always false"/> <location file="src/s3fs_util.cpp" line="994" column="17" info="Assignment 'result=false', assigned value is 0"/> </error> <error id="knownConditionTrueFalse" severity="style" msg="Condition 'result' is always false" verbose="Condition 'result' is always false" cwe="570"> <location file="src/s3fs_util.cpp" line="1003" column="12" info="Condition 'result' is always false"/> <location file="src/s3fs_util.cpp" line="994" column="17" info="Assignment 'result=false', assigned value is 0"/> </error> <error id="knownConditionTrueFalse" severity="style" msg="Condition 'result' is always false" verbose="Condition 'result' is always false" cwe="570"> <location file="src/s3fs_util.cpp" line="1008" column="12" info="Condition 'result' is always false"/> <location file="src/s3fs_util.cpp" line="994" column="17" info="Assignment 'result=false', assigned value is 0"/> </error> ``` ### Details about issue I will make a patch as soon as possible.