mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 13:26:00 +03:00
[GH-ISSUE #976] Preparation for release of version 1.85 #543
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#543
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ggtakec on GitHub (Mar 10, 2019).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/976
Additional Information
Multiple defects have been fixed.
And upload, readdir performance is also improved.
Details about issue
We will prepare for the release of the new version 1.85.
Appreciation
Thanks to your cooperation, I was able to make it a better application.
I greatly appreciate their cooperation that gave me the PR listed below.
@Basavaraju013
@DreamFlasher
@earlchew
@gaul
@JoohnSF
@juliogonzalez
@kristjanvalur
@kzidane
@LutzFinsterle2019
@mapreri
@mcgitty
@orozery
@soulprovidr
@ggtakec commented on GitHub (Mar 11, 2019):
Launched new release 1.85 now.
https://github.com/s3fs-fuse/s3fs-fuse/releases/tag/v1.85
Appreciation
Thanks @Basavaraju013 @DreamFlasher @earlchew @gaul @JoohnSF @juliogonzalez @kristjanvalur @kzidane @LutzFinsterle2019 @mapreri @mcgitty @orozery @soulprovidr @sqlbot .
This version has been able to fix bugs, improve performance, and other enhancements.
Your help was much appreciated.
I could not have done this new release without you.
New owner member
And @gaul has joined s3fs-fuse owner member from this version release.
We will continue to cooperate and improve s3fs-fuse.
Please packaging
@mapreri @jollyroger
Just let you know, new release 1.85 version is tagged now.
Please check and start to package it if it have no problem.
Thanks in advance for your assistance.
@ggtakec commented on GitHub (Mar 12, 2019):
I found a bug report #979 .
This version does not contain any fixes and will be fixed in the next update.
@juliogonzalez commented on GitHub (Mar 12, 2019):
Did we break compatibility with RHEL6/CentOS6?
While preparing the SPEC for v1.85 (https://github.com/juliogonzalez/s3fs-fuse-rpm/pull/11) I found that s3fs-fuse does not compile anymore for CentOS6: https://jenkins.juliogonzalez.es/job/s3fs-fuse-rpm-build-pr/41/DISTRO=centos6,label=docker/console
Could it be that curl at CentOS6 is not compatible anymore?
@ggtakec commented on GitHub (Mar 12, 2019):
CURLOPT_TCP_KEEPALIVE is an option supported by curl version 7.25.0 or later. Can't use this version?
@juliogonzalez commented on GitHub (Mar 12, 2019):
I am afraid CentOS6 has only 7.19:
Must say that CentOS6 already required a build of fuse different by the one provided by the distribution (fuse there is just too old).
So of course I could provide a libcurl spec for those still using CentOS6.
But I wonder if it's useful keep replacing more and more packages, or if we should just mark >= 1.85 not compatible with CentOS6 anymore.
@ggtakec commented on GitHub (Mar 13, 2019):
Thanks replying.
We will consider continuing support for centos6. In addition, please wait in a day.
@gaul please give us your opinion.
Additional information, if CURL_option that is not supported is specified for curl_easy_setopt, it will only generate an error and it will not affect the operation.
A case of s3fs, there is no problem due to this option not being set, and the performance is just as usual.
@juliogonzalez commented on GitHub (Mar 13, 2019):
@ggtakec no problem, I can wait.
In fact I can submit the spec to Fedora and EPEL7, as anyway I am not officially providing the package for EPEL6 :-)
So I will do that tomorrow, and I will wait for your instructions to see what to do about the wiki (here), and about my unofficial support for RPMs for CentOS/RHEL6.
@ggtakec commented on GitHub (Mar 13, 2019):
Thanks, please wait in a day.
@gaul commented on GitHub (Mar 14, 2019):
Generally we should not make accommodations for CentOS 6 since it already requires newer FUSE. However specifically for libcurl, we want to enable
CURLOPT_SSL_ENABLE_ALPNandCURLOPT_KEEP_SENDING_ON_ERRORoptions which require newer curl. We could conditionally compile these andCURLOPT_TCP_KEEPALIVEfor CentOS 6 via#if LIBCURL_VERSION_NUM >= 0xXXYYZZ.@ggtakec commented on GitHub (Mar 14, 2019):
The following will be not included in version 1.85, but be supported on 1.86 and later.
I will prepare the code with CURLOPT_TCP_KEEPALIVE, CURLOPT_SSL_ENABLE_ALPN and CURLOPT_KEEP_SENDING_ON_ERROR support later on.
It will be implemented to be included in the s3fs code, regardless of the version of libcurl used for building.
This is to be able to build so that it does not depend on the libcurl version, not on CentOS 6 support.
This will enable or disable these options depending on the version of libcurl that s3fs links with at runtime.
@juliogonzalez commented on GitHub (Mar 16, 2019):
@ggtakec when you have the code ready, please ping and I will try to create a patch for the 1.85 RPM, so 1.85 also works with older curl versions and users don't need to wait for 1.86 :-)
@juliogonzalez commented on GitHub (Mar 16, 2019):
@ggtakec BTW, for upcoming versions you can ping me at "Please packaging", as I am the package maintainer at Fedora/CentOS/RHEL, and also help (but I am not the official maintainer) at openSUSE/SUSE
@muryoutaisuu commented on GitHub (Mar 22, 2019):
@juliogonzalez I found this solution at RedHat https://access.redhat.com/solutions/2608331 stating there's no support for s3fs-fuse, but you are the package maintainer at RHEL for this software. How does that work? You just create the .rpm files for convenience while RedHat still won't provide full support? Is that correct?
I'm just asking because since upgrade of RHEL7.5 to RHEL7.6 we're experiencing a lot of D-State processes with s3fs-fuse and I'm suspecting RedHat broke something. So I'm still somehow wondering whether it's supported or not.
@ggtakec commented on GitHub (Mar 22, 2019):
@juliogonzalez
I merged #987 to fix CURLoption issue.
You can build s3fs using libcurl where these CURLoptions are not defined.
The s3fs created supports these options, even though they were built using the old libcurl.
And I merged #985 which fixed https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923581.
Please try creating the s3fs package.
@ggtakec commented on GitHub (Mar 22, 2019):
@juliogonzalez We would like to ask you to help with Fedora / CentOS / RHEL.
And also for openSUSE / SUSE packages.
Thanks in advance for your help.
@ggtakec commented on GitHub (Mar 22, 2019):
@muryoutaisuu
Because I am not authorized(?), I can not see the details of the following contents.
https://access.redhat.com/solutions/2608331
If you like, please send us details as an issue and we can start working on it.
Thanks in advance for your assistance.
@muryoutaisuu commented on GitHub (Mar 22, 2019):
@ggtakec it essentially just states:
Last updated March 8 2018 at 6:07 AM, state of ticket is "SOLUTION IN PROGRESS", whatever that means.
I'll open an issue, although for the meantime we've switched to s3cmd & cronjob, as we need a workaround on our production systems.
@juliogonzalez commented on GitHub (Mar 22, 2019):
@muryoutaisuu, I am the package maintainer for Fedora, and EPEL, but not for RHEL. It's up to RHEL to decided the packages they include from Fedora or EPEL, and what the support status is. I was not even aware they include it at any RHEL6/7, and assumed s3fs-fuse was available at EPEL only.
@ggtakec, thanks, I will apply the patch on top of 1.85, and that should fix the issues, and if so, I will submit to Fedora/EPEL (EPEL provides packages for CentOS and RHEL).
Regarding SUSE and openSUSE, submission was done the day after 1.85 was released (https://build.opensuse.org/request/show/684501), but it's pending review yet. I will ping Robert on Monday.
@juliogonzalez commented on GitHub (Mar 22, 2019):
SPEC updated: https://github.com/juliogonzalez/s3fs-fuse-rpm/releases/tag/1.85-1
Submissions:
Fedora 30 is now on Beta Freeze, so package will be accepted only during next milestone, or maybe after release.
@mapreri commented on GitHub (Mar 23, 2019):
@jollyroger did you have any chance of working on this?
Note however that Debian is frozen right now, so we can upload it only to experimental and target the next stable release Debian 10.
@mapreri commented on GitHub (Mar 23, 2019):
(btw, thanks for
df604e50fbthat I forgot to forward to you; pity it didn't make in time for the release :))@ggtakec commented on GitHub (Mar 24, 2019):
@muryoutaisuu
Thanks for your issue #988, and we will check it.
@ggtakec commented on GitHub (Mar 24, 2019):
@juliogonzalez
That is great and Thanks for your assistance.
@ggtakec commented on GitHub (Mar 24, 2019):
@mapreri
Thanks for your comments, and we hope and wait next release.
@gaul commented on GitHub (Apr 9, 2019):
@ggtakec can we close this issue?
@ggtakec commented on GitHub (Apr 9, 2019):
@gaul It closes once here.
Thank you.