[GH-ISSUE #678] Improve use of temporary files #382

Closed
opened 2026-03-04 01:45:01 +03:00 by kerem · 2 comments
Owner

Originally created by @gaul on GitHub (Nov 18, 2017).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/678

GCC complains about one use of tmpnam:

fdcache.o: In function `FdEntity::OpenMirrorFile()':
/home/gaul/work/s3fs-fuse/src/fdcache.cpp:761: warning: the use of `tmpnam' is dangerous, better use `mkstemp'

Coverity complains about four uses of tmpfile, recommending mkstemp instead:

https://scan3.coverity.com/doc/en/cov_checker_ref.html#static_checker_SECURE_TEMP

Originally created by @gaul on GitHub (Nov 18, 2017). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/678 GCC complains about one use of `tmpnam`: ``` fdcache.o: In function `FdEntity::OpenMirrorFile()': /home/gaul/work/s3fs-fuse/src/fdcache.cpp:761: warning: the use of `tmpnam' is dangerous, better use `mkstemp' ``` Coverity complains about four uses of `tmpfile`, recommending `mkstemp` instead: https://scan3.coverity.com/doc/en/cov_checker_ref.html#static_checker_SECURE_TEMP
kerem closed this issue 2026-03-04 01:45:01 +03:00
Author
Owner

@ggtakec commented on GitHub (Nov 19, 2017):

@gaul Yes, thanks.
I found another warnning lines(JSONCPP in curl.cpp, singed/unsigned in curl.cpp) in latest codes, and I will try to fix.
Please wait a moment.

<!-- gh-comment-id:345512425 --> @ggtakec commented on GitHub (Nov 19, 2017): @gaul Yes, thanks. I found another warnning lines(JSONCPP in curl.cpp, singed/unsigned in curl.cpp) in latest codes, and I will try to fix. Please wait a moment.
Author
Owner

@ggtakec commented on GitHub (Nov 23, 2017):

Fixed by #688, thus closing this issue.

<!-- gh-comment-id:346573197 --> @ggtakec commented on GitHub (Nov 23, 2017): Fixed by #688, thus closing this issue.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#382
No description provided.