[PR #2789] [MERGED] Fix memory leaks in multipart upload error paths #2793

New issue

Closed

opened 2026-03-04 02:07:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:07:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2789
Author: @CarstenGrohmann
Created: 1/23/2026
Status: ✅ Merged
Merged: 1/23/2026
Merged by: @gaul

Base: master ← Head: fix_multipart_leaks

📝 Commits (1)

ad10d48 Fix memory leaks in multipart upload error paths

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/s3fs_threadreqs.cpp (+2 -0)

📄 Description

Delete thargs when ThreadPoolMan::Instruct() or AwaitInstruct() fails. The thread parameter struct was allocated with new but never freed when the thread pool rejected the work item, causing a memory leak on each failed multipart upload part request.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2789 **Author:** [@CarstenGrohmann](https://github.com/CarstenGrohmann) **Created:** 1/23/2026 **Status:** ✅ Merged **Merged:** 1/23/2026 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_multipart_leaks` --- ### 📝 Commits (1) - [`ad10d48`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ad10d4899ef5aa398d5cb381e36161e8a605a87b) Fix memory leaks in multipart upload error paths ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs_threadreqs.cpp` (+2 -0) </details> ### 📄 Description Delete thargs when `ThreadPoolMan::Instruct()` or `AwaitInstruct()` fails. The thread parameter struct was allocated with new but never freed when the thread pool rejected the work item, causing a memory leak on each failed multipart upload part request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>