[PR #2783] [MERGED] Changed to not call PreventStatCacheExpire #2786

New issue

Closed

opened 2026-03-04 02:07:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:07:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2783
Author: @ggtakec
Created: 1/11/2026
Status: ✅ Merged
Merged: 2/6/2026
Merged by: @gaul

Base: master ← Head: fix/stat_expire

📝 Commits (1)

78ace44 Changed to not call PreventStatCacheExpire

📊 Changes

1 file changed (+10 additions, -2 deletions)

View changed files

📝 src/s3fs.cpp (+10 -2)

📄 Description

Relevant Issue (if applicable)

n/a

Details

Current s3fs is preventing removing the stat cache data during rmdir/mkdir operations, but I found it has a problem.
Thus I have commented out this prevention measure.
(I will restore it after correcting the problematic processing, but for now I will not call it.)

Normally, when s3fs retrieves stat data for files (and directories), it checks the expiration date of the stat cache if one exists.
For current rmdir/mkdir, bypass the cache out check.
However, the following issue was discovered with this logic.
That is if there is cached data that has already passed its expiration date, processing will continue without caching that data out.
This could result in inconsistencies.

This issue is thought to have caused the test_truncate_cache test to fail during the cleanup process (directory deletion) after the test is completed.

Further observation

This issue may have caused test times on macOS and other systems to be extremely long.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2783 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 1/11/2026 **Status:** ✅ Merged **Merged:** 2/6/2026 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/stat_expire` --- ### 📝 Commits (1) - [`78ace44`](https://github.com/s3fs-fuse/s3fs-fuse/commit/78ace4498bd424d1650de5343224ba0b2512d709) Changed to not call PreventStatCacheExpire ### 📊 Changes **1 file changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+10 -2) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details Current s3fs is preventing removing the stat cache data during rmdir/mkdir operations, but I found it has a problem. Thus I have commented out this prevention measure. _(I will restore it after correcting the problematic processing, but for now I will not call it.)_ Normally, when s3fs retrieves stat data for files (and directories), it checks the expiration date of the stat cache if one exists. For current rmdir/mkdir, bypass the cache out check. However, the following issue was discovered with this logic. That is if there is cached data that has already passed its expiration date, processing will continue without caching that data out. This could result in inconsistencies. This issue is thought to have caused the test_truncate_cache test to fail during the cleanup process (directory deletion) after the test is completed. #### Further observation This issue may have caused test times on macOS and other systems to be extremely long. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>