[PR #2768] [MERGED] Micro-optimize copies, compares, and logging #2778

New issue

Closed

opened 2026-03-04 02:07:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:07:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2768
Author: @gaul
Created: 12/4/2025
Status: ✅ Merged
Merged: 12/6/2025
Merged by: @ggtakec

Base: master ← Head: microopt

📝 Commits (1)

85c887e Micro-optimize copies, compares, and logging

📊 Changes

8 files changed (+67 additions, -82 deletions)

View changed files

📝 src/cache_node.cpp (+3 -3)
📝 src/curl_util.cpp (+3 -3)
📝 src/fdcache.cpp (+1 -1)
📝 src/s3fs_logger.cpp (+29 -33)
📝 src/s3fs_logger.h (+6 -2)
📝 src/s3fs_util.cpp (+12 -26)
📝 src/s3fs_util.h (+2 -4)
📝 src/string_util.cpp (+11 -10)

📄 Description

Logging should eagerly evaluate the log level to avoid unnecessary calls to parameters like calls to STR_OBJTYPE. These contributed to slow Valgrind test run-times.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2768 **Author:** [@gaul](https://github.com/gaul) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 12/6/2025 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `microopt` --- ### 📝 Commits (1) - [`85c887e`](https://github.com/s3fs-fuse/s3fs-fuse/commit/85c887ed4cb725a99f42af69c1aea89229b925a9) Micro-optimize copies, compares, and logging ### 📊 Changes **8 files changed** (+67 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `src/cache_node.cpp` (+3 -3) 📝 `src/curl_util.cpp` (+3 -3) 📝 `src/fdcache.cpp` (+1 -1) 📝 `src/s3fs_logger.cpp` (+29 -33) 📝 `src/s3fs_logger.h` (+6 -2) 📝 `src/s3fs_util.cpp` (+12 -26) 📝 `src/s3fs_util.h` (+2 -4) 📝 `src/string_util.cpp` (+11 -10) </details> ### 📄 Description Logging should eagerly evaluate the log level to avoid unnecessary calls to parameters like calls to `STR_OBJTYPE`. These contributed to slow Valgrind test run-times. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>