[PR #2724] [MERGED] Fixed test_external_modification test for MacOS #2744

New issue

Closed

opened 2026-03-04 02:07:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:07:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2724
Author: @ggtakec
Created: 8/30/2025
Status: ✅ Merged
Merged: 9/1/2025
Merged by: @gaul

Base: master ← Head: fix/mac_test_cfs

📝 Commits (1)

9a1caee Fixed test_external_modification test for MacOS

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 test/integration-test-main.sh (+7 -0)

📄 Description

Relevant Issue (if applicable)

n/a

Details

In a recent CI(GHA) run, the test_external_modification test on macOS often failed.
I investigated the cause and have now found it, so I posted this PR.

The cause was a difference in the way getattr calls are made from FUSE on macOS and other Linuxs.
In the test_external_modification test, after uploading a file, it waits one second(while the file contents are modified by external process) and then reads it.
On other Linuxs, there is no getattr call after uploading, but on macOS, the getattr call is made.

The stat_cache_interval_expire=1 option was set for s3fs when the test was run, so if the cache is accessed via a getattr call within the cache expiration period, the expiration period is extended.
For this reason, the getattr call is made on macOS, and waiting 1 second will still be within the cache expiration period.

To avoid this, added an additional 1-second sleep on macOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2724 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 8/30/2025 **Status:** ✅ Merged **Merged:** 9/1/2025 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/mac_test_cfs` --- ### 📝 Commits (1) - [`9a1caee`](https://github.com/s3fs-fuse/s3fs-fuse/commit/9a1caeec78a5f24cea38c71a8ce0bcbb67702681) Fixed test_external_modification test for MacOS ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `test/integration-test-main.sh` (+7 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details In a recent CI(GHA) run, the `test_external_modification` test on macOS often failed. I investigated the cause and have now found it, so I posted this PR. The cause was a difference in the way `getattr` calls are made from FUSE on macOS and other Linuxs. In the `test_external_modification` test, after uploading a file, it waits one second(while the file contents are modified by external process) and then reads it. On other Linuxs, there is no `getattr` call after uploading, but on macOS, the `getattr` call is made. The `stat_cache_interval_expire=1` option was set for s3fs when the test was run, so if the cache is accessed via a `getattr` call within the cache expiration period, the expiration period is extended. For this reason, the `getattr` call is made on macOS, and waiting 1 second will still be within the cache expiration period. To avoid this, added an additional 1-second sleep on macOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>