mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 05:16:00 +03:00
[PR #2690] [CLOSED] Create random string with date without /dev/urandom #2714
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#2714
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2690
Author: @ggtakec
Created: 6/23/2025
Status: ❌ Closed
Base:
master← Head:fix/urandom📝 Commits (1)
93c6408Create random string with date without /dev/urandom📊 Changes
2 files changed (+10 additions, -10 deletions)
View changed files
📝
test/integration-test-main.sh(+2 -2)📝
test/test-utils.sh(+8 -8)📄 Description
Relevant Issue (if applicable)
#2687
Details
In the function for adding suffixes to test file names, I changed it so that it does not use
/dev/urandom, but uses a random string using seconds and microseconds from thedatecommand.Why was this necessary?
I did not understand the root cause of this.
However, it seems that the phenomenon is related to
/dev/urandomused in themake_random_stringtest utility function for MacOS.In order to proceed with the problem phenomenon #2687, I was investigating the test results of
test_update_metadata_external_small(large)_object.And I found an abnormal slowdown in processing speed that sometimes occurred on MacOS.
This was caused by processing being blocked in the following part.
I tried many things such as changing the way the
make_random_stringfunction is called, but as long as/dev/urandomis used, this problem continues to occur.In particular, when running Github Actions (CI) with
dbglevel=dbg, the blocking is noticeable.The block mentioned here means that the s3fs-fuse test script is blocked from running.
While this is blocked, s3fs-fuse periodically references the
/and/test-XXXXdirectories.(For example,
s3fs_getattrscalled bymacos-fuse-t.)About the solution
The fundamental solution to this problem is still unknown.
This is a very strange and difficult problem to understand.
But we need to avoid blocking work that was not essential to our tests, so I change it to not access
/dev/urandomas a simple solution.If possible, it would be a good idea to try only the above test cases at dbg level on MacOS.
I would also like some advice on this matter.
Note
This problem is blocking #2687.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.