[PR #2685] [MERGED] Removed the RUN_DIR variable which is no longer global #2708

New issue

Closed

opened 2026-03-04 02:06:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2685
Author: @ggtakec
Created: 6/8/2025
Status: ✅ Merged
Merged: 6/9/2025
Merged by: @gaul

Base: master ← Head: fix/rundir_env

📝 Commits (1)

50a763b Removed the RUN_DIR variable which is no longer global

📊 Changes

1 file changed (+16 additions, -5 deletions)

View changed files

📝 test/test-utils.sh (+16 -5)

📄 Description

Relevant Issue (if applicable)

n/a

Details

The RUN_DIR variable is no longer a global variable(since when?).
This also caused the clean_run_dir function to no longer work.
As a result, the top directory specified by RUN_DIR remained in each test.

So, fixed clean_run_dir function that the RUN_DIR value was now passed as an argument, and export declarations have also been deleted.
This ensures that the directory used when the test is completed is deleted reliably.
Meaningless directory accesses no longer appeared in the logs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2685 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 6/8/2025 **Status:** ✅ Merged **Merged:** 6/9/2025 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/rundir_env` --- ### 📝 Commits (1) - [`50a763b`](https://github.com/s3fs-fuse/s3fs-fuse/commit/50a763b3916e4082c0ef85883ae017bbf0c98df3) Removed the RUN_DIR variable which is no longer global ### 📊 Changes **1 file changed** (+16 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `test/test-utils.sh` (+16 -5) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details The `RUN_DIR` variable is no longer a global variable(since when?). This also caused the `clean_run_dir` function to no longer work. As a result, the top directory specified by `RUN_DIR` remained in each test. So, fixed `clean_run_dir` function that the `RUN_DIR` value was now passed as an argument, and export declarations have also been deleted. This ensures that the directory used when the test is completed is deleted reliably. Meaningless directory accesses no longer appeared in the logs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>