[PR #2676] [MERGED] Refactor to move functions and its declarations to appropriate files #2701

New issue

Closed

opened 2026-03-04 02:06:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2676
Author: @ggtakec
Created: 5/31/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @gaul

Base: master ← Head: stat/03_movefunc

📝 Commits (1)

1750f33 Refactor to move functions and its declarations to appropriate files

📊 Changes

6 files changed (+72 additions, -77 deletions)

View changed files

📝 src/cache.cpp (+0 -71)
📝 src/cache.h (+0 -5)
📝 src/curl.cpp (+1 -0)
📝 src/metaheader.cpp (+69 -0)
📝 src/metaheader.h (+1 -1)
📝 src/s3fs_threadreqs.cpp (+1 -0)

📄 Description

Relevant Issue (if applicable)

#2674 #2675

Details

This PR is Phase 3 of fixes to refactor and improve StatCache.
(Draft until #2675 is merged. Subsequent PRs will follow based on this PR codes.)

The definition and declaration of convert_header_to_stat function has been moved.(The contents of the function have not changed.)
An unnecessary declaration of simple_parse_xml has been deleted.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2676 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/31/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `stat/03_movefunc` --- ### 📝 Commits (1) - [`1750f33`](https://github.com/s3fs-fuse/s3fs-fuse/commit/1750f33efde61351f465fb43de6f453fe92b2aa1) Refactor to move functions and its declarations to appropriate files ### 📊 Changes **6 files changed** (+72 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `src/cache.cpp` (+0 -71) 📝 `src/cache.h` (+0 -5) 📝 `src/curl.cpp` (+1 -0) 📝 `src/metaheader.cpp` (+69 -0) 📝 `src/metaheader.h` (+1 -1) 📝 `src/s3fs_threadreqs.cpp` (+1 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #2674 #2675 ### Details This PR is Phase 3 of fixes to refactor and improve StatCache. (Draft until #2675 is merged. Subsequent PRs will follow based on this PR codes.) - The definition and declaration of `convert_header_to_stat` function has been moved.(The contents of the function have not changed.) - An unnecessary declaration of `simple_parse_xml` has been deleted. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>