[PR #2675] [MERGED] Refactor StatCache words from NoObject to Negative #2700

New issue

Closed

opened 2026-03-04 02:06:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2675
Author: @ggtakec
Created: 5/31/2025
Status: ✅ Merged
Merged: 6/10/2025
Merged by: @gaul

Base: master ← Head: stat/02_negative

📝 Commits (1)

fb60942 Refactor StatCache words from NoObject to Negative

📊 Changes

5 files changed (+47 additions, -32 deletions)

View changed files

📝 doc/man/s3fs.1.in (+13 -7)
📝 src/cache.cpp (+7 -7)
📝 src/cache.h (+8 -8)
📝 src/s3fs.cpp (+5 -5)
📝 src/s3fs_help.cpp (+14 -5)

📄 Description

Relevant Issue (if applicable)

#2674

Details

This PR is Phase 2 of fixes to refactor and improve StatCache.
(Draft until #2674 is merged. Subsequent PRs will follow based on this PR codes.)

The word NoObjectCache has been changed to NegativeCache because its meaning is ambiguous and misleading.

We should distinguish clearly within s3fs between the case where the object (file) does not exist and the case where the object does not exist as a directory path but a child object does, so we are changing it to the word Negative.

In conjunction with this, we are also changing the name of the existing option disable_noobj_cache to disable_negative_cache.
The old option will be deprecated, but will continue to be supported.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2675 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/31/2025 **Status:** ✅ Merged **Merged:** 6/10/2025 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `stat/02_negative` --- ### 📝 Commits (1) - [`fb60942`](https://github.com/s3fs-fuse/s3fs-fuse/commit/fb60942bb65ccdac1497122cb5f508f76462b625) Refactor StatCache words from NoObject to Negative ### 📊 Changes **5 files changed** (+47 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `doc/man/s3fs.1.in` (+13 -7) 📝 `src/cache.cpp` (+7 -7) 📝 `src/cache.h` (+8 -8) 📝 `src/s3fs.cpp` (+5 -5) 📝 `src/s3fs_help.cpp` (+14 -5) </details> ### 📄 Description ### Relevant Issue (if applicable) #2674 ### Details This PR is Phase 2 of fixes to refactor and improve StatCache. (Draft until #2674 is merged. Subsequent PRs will follow based on this PR codes.) The word `NoObjectCache` has been changed to `NegativeCache` because its meaning is ambiguous and misleading. We should distinguish clearly within s3fs between the case where the object (file) does not exist and the case where the object does not exist as a directory path but a child object does, so we are changing it to the word `Negative`. In conjunction with this, we are also changing the name of the existing option `disable_noobj_cache` to `disable_negative_cache`. The old option will be deprecated, but will continue to be supported. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>