[PR #2602] [MERGED] Refactored single type requests to use through ThreadPoolMan #2659

New issue

Closed

opened 2026-03-04 02:06:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2602
Author: @ggtakec
Created: 11/10/2024
Status: ✅ Merged
Merged: 11/12/2024
Merged by: @gaul

Base: master ← Head: multi/2_use_threadpool

📝 Commits (1)

d494604 Refactored single type requests to use through ThreadPoolMan

📊 Changes

16 files changed (+1463 additions, -456 deletions)

View changed files

📝 src/Makefile.am (+1 -0)
📝 src/curl.cpp (+68 -89)
📝 src/curl.h (+19 -22)
📝 src/fdcache_entity.cpp (+258 -96)
📝 src/fdcache_entity.h (+5 -3)
📝 src/fdcache_fdinfo.cpp (+52 -16)
📝 src/fdcache_fdinfo.h (+1 -18)
📝 src/mpu_util.cpp (+2 -5)
📝 src/s3fs.cpp (+181 -152)
📝 src/s3fs_cred.cpp (+50 -49)
📝 src/s3fs_cred.h (+15 -5)
📝 src/s3fs_help.cpp (+1 -1)
➕ src/s3fs_threadreqs.cpp (+591 -0)
➕ src/s3fs_threadreqs.h (+187 -0)
📝 src/threadpoolman.cpp (+31 -0)
📝 src/threadpoolman.h (+1 -0)

📄 Description

Relevant Issue (if applicable)

#2600

Details

This is the split PR Phase 2 (2/8) for #2600.

Single requests(synchronous requests) are changed to process by a worker thread managed by ThreadPoolMan.

The implementation of each request process has been moved to the handler(Callback) function of the worker thread.
As a result, the S3fsCurl object held by each request process function has been moved to a worker thread managed by ThreadPoolMan.
(In a future PR, the construction location of the S3fsCurl object will be moved again.)
All worker thread processing is concentrated in new s3fs_threadreqs.cpp file.
(From now on, I will continue to concentrate in this file.)

Asynchronous and multi-request processing is not yet modified in this PR.

This PR will be rebased and removed from draft status once the previous PR(#2601) is merged into master.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2602 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 11/10/2024 **Status:** ✅ Merged **Merged:** 11/12/2024 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `multi/2_use_threadpool` --- ### 📝 Commits (1) - [`d494604`](https://github.com/s3fs-fuse/s3fs-fuse/commit/d494604267f31d3edc74755a967c4a65193519f2) Refactored single type requests to use through ThreadPoolMan ### 📊 Changes **16 files changed** (+1463 additions, -456 deletions) <details> <summary>View changed files</summary> 📝 `src/Makefile.am` (+1 -0) 📝 `src/curl.cpp` (+68 -89) 📝 `src/curl.h` (+19 -22) 📝 `src/fdcache_entity.cpp` (+258 -96) 📝 `src/fdcache_entity.h` (+5 -3) 📝 `src/fdcache_fdinfo.cpp` (+52 -16) 📝 `src/fdcache_fdinfo.h` (+1 -18) 📝 `src/mpu_util.cpp` (+2 -5) 📝 `src/s3fs.cpp` (+181 -152) 📝 `src/s3fs_cred.cpp` (+50 -49) 📝 `src/s3fs_cred.h` (+15 -5) 📝 `src/s3fs_help.cpp` (+1 -1) ➕ `src/s3fs_threadreqs.cpp` (+591 -0) ➕ `src/s3fs_threadreqs.h` (+187 -0) 📝 `src/threadpoolman.cpp` (+31 -0) 📝 `src/threadpoolman.h` (+1 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #2600 ### Details This is the split PR Phase 2 (2/8) for #2600. Single requests(synchronous requests) are changed to process by a worker thread managed by `ThreadPoolMan`. The implementation of each request process has been moved to the handler(Callback) function of the worker thread. As a result, the `S3fsCurl` object held by each request process function has been moved to a worker thread managed by `ThreadPoolMan`. (In a future PR, the construction location of the `S3fsCurl` object will be moved again.) All worker thread processing is concentrated in new `s3fs_threadreqs.cpp` file. (From now on, I will continue to concentrate in this file.) Asynchronous and multi-request processing is not yet modified in this PR. This PR will be rebased and removed from draft status once the previous PR(#2601) is merged into master. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>