[PR #2601] [MERGED] Removed CurlHandlerPool and simplified it #2657

New issue

Closed

opened 2026-03-04 02:06:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2601
Author: @ggtakec
Created: 11/10/2024
Status: ✅ Merged
Merged: 11/11/2024
Merged by: @gaul

Base: master ← Head: multi/1_rm_curlpool

📝 Commits (1)

27dd132 Removed CurlHandlerPool and simplified it

📊 Changes

8 files changed (+17 additions, -239 deletions)

View changed files

📝 src/Makefile.am (+0 -1)
📝 src/curl.cpp (+12 -33)
📝 src/curl.h (+3 -6)
➖ src/curl_handlerpool.cpp (+0 -114)
➖ src/curl_handlerpool.h (+0 -74)
📝 src/curl_multi.cpp (+1 -1)
📝 src/fdcache_fdinfo.cpp (+1 -7)
📝 src/fdcache_fdinfo.h (+0 -3)

📄 Description

Relevant Issue (if applicable)

#2600

Details

This is the split PR Phase 1 (1/8) for #2600.

In this PR, we remove CurlHandlerPool and change it so that it is not used.
Accordingly, CurlHandle will be stored inside the S3fsCurl object.
I also removed unused class variables that were detected during the modification.

In addition, CURL_LOCK_DATA_SSL_SESSION is disabled in this PR for the following PRs. (It will be re-enabled eventually.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2601 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 11/10/2024 **Status:** ✅ Merged **Merged:** 11/11/2024 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `multi/1_rm_curlpool` --- ### 📝 Commits (1) - [`27dd132`](https://github.com/s3fs-fuse/s3fs-fuse/commit/27dd132038af40a9750717f1683dbf11998669ac) Removed CurlHandlerPool and simplified it ### 📊 Changes **8 files changed** (+17 additions, -239 deletions) <details> <summary>View changed files</summary> 📝 `src/Makefile.am` (+0 -1) 📝 `src/curl.cpp` (+12 -33) 📝 `src/curl.h` (+3 -6) ➖ `src/curl_handlerpool.cpp` (+0 -114) ➖ `src/curl_handlerpool.h` (+0 -74) 📝 `src/curl_multi.cpp` (+1 -1) 📝 `src/fdcache_fdinfo.cpp` (+1 -7) 📝 `src/fdcache_fdinfo.h` (+0 -3) </details> ### 📄 Description ### Relevant Issue (if applicable) #2600 ### Details This is the split PR Phase 1 (1/8) for #2600. In this PR, we remove CurlHandlerPool and change it so that it is not used. Accordingly, CurlHandle will be stored inside the S3fsCurl object. I also removed unused class variables that were detected during the modification. In addition, `CURL_LOCK_DATA_SSL_SESSION` is disabled in this PR for the following PRs. (It will be re-enabled eventually.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>