[PR #2556] [MERGED] Remove more raw pointers #2621

Closed
opened 2026-03-04 02:06:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2556
Author: @gaul
Created: 10/19/2024
Status: Merged
Merged: 10/20/2024
Merged by: @ggtakec

Base: masterHead: unique_ptr/more


📝 Commits (1)

📊 Changes

5 files changed (+15 additions, -20 deletions)

View changed files

📝 src/curl.cpp (+3 -4)
📝 src/curl.h (+1 -1)
📝 src/openssl_auth.cpp (+3 -4)
📝 src/threadpoolman.cpp (+6 -9)
📝 src/threadpoolman.h (+2 -2)

📄 Description

Make destructor public so std::unique_ptr can call it. Also restrict singleton creation to satisfy cppcheck.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2556 **Author:** [@gaul](https://github.com/gaul) **Created:** 10/19/2024 **Status:** ✅ Merged **Merged:** 10/20/2024 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `unique_ptr/more` --- ### 📝 Commits (1) - [`7af9e32`](https://github.com/s3fs-fuse/s3fs-fuse/commit/7af9e32b0016a3ebb1bc205add612ba921450843) Remove more raw pointers ### 📊 Changes **5 files changed** (+15 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+3 -4) 📝 `src/curl.h` (+1 -1) 📝 `src/openssl_auth.cpp` (+3 -4) 📝 `src/threadpoolman.cpp` (+6 -9) 📝 `src/threadpoolman.h` (+2 -2) </details> ### 📄 Description Make destructor public so `std::unique_ptr` can call it. Also restrict singleton creation to satisfy cppcheck. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:06:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2621
No description provided.