[PR #2549] [MERGED] Add missing `GUARDED_BY` to `fdcache_entity` #2615

New issue

Closed

opened 2026-03-04 02:06:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2549
Author: @gaul
Created: 10/14/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @ggtakec

Base: master ← Head: guarded-by

📝 Commits (1)

c3208d6 Add missing GUARDED_BY to fdcache_entity

📊 Changes

5 files changed (+22 additions, -62 deletions)

View changed files

📝 src/common.h (+3 -0)
📝 src/fdcache_entity.cpp (+1 -42)
📝 src/fdcache_entity.h (+15 -18)
📝 src/fdcache_fdinfo.h (+2 -2)
📝 src/sighandlers.cpp (+1 -0)

📄 Description

This requires a fake GetMutex for the lock checker to understand the control flow. Also remove unneeded locking comments that annotation supersede. Follows on to #2491.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2549 **Author:** [@gaul](https://github.com/gaul) **Created:** 10/14/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `guarded-by` --- ### 📝 Commits (1) - [`c3208d6`](https://github.com/s3fs-fuse/s3fs-fuse/commit/c3208d6a7e08d2d826668815701e55081cb9a7e3) Add missing GUARDED_BY to fdcache_entity ### 📊 Changes **5 files changed** (+22 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `src/common.h` (+3 -0) 📝 `src/fdcache_entity.cpp` (+1 -42) 📝 `src/fdcache_entity.h` (+15 -18) 📝 `src/fdcache_fdinfo.h` (+2 -2) 📝 `src/sighandlers.cpp` (+1 -0) </details> ### 📄 Description This requires a fake `GetMutex` for the lock checker to understand the control flow. Also remove unneeded locking comments that annotation supersede. Follows on to #2491. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>