[PR #2545] [MERGED] Fixed exclusive control of upload_id in PseudoFdInfo class #2611

New issue

Closed

opened 2026-03-04 02:06:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2545
Author: @ggtakec
Created: 10/13/2024
Status: ✅ Merged
Merged: 10/15/2024
Merged by: @gaul

Base: master ← Head: fix/fdinfo_lock

📝 Commits (1)

432834f Fixed exclusive control of upload_id in PseudoFdInfo class

📊 Changes

2 files changed (+97 additions, -56 deletions)

View changed files

📝 src/fdcache_fdinfo.cpp (+81 -43)
📝 src/fdcache_fdinfo.h (+16 -13)

📄 Description

Relevant Issue (if applicable)

#2493 #2487 #254

Details

This was modified to minimize exclusive control of the PseudoFdInfo::upload_id variable.
To achieve this, IsUploadingHasLock() is added, which does not hold the IsUploading() lock, to streamline the locking process on the caller side.
As a result of this efficiency, it is no longer necessary to lock before calling ParallelMultipartUpload().
Please refer to the code for detailed differences.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2545 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 10/13/2024 **Status:** ✅ Merged **Merged:** 10/15/2024 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/fdinfo_lock` --- ### 📝 Commits (1) - [`432834f`](https://github.com/s3fs-fuse/s3fs-fuse/commit/432834ff98bdc9d0e5c55d3272810e2c1c9bfe3b) Fixed exclusive control of upload_id in PseudoFdInfo class ### 📊 Changes **2 files changed** (+97 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_fdinfo.cpp` (+81 -43) 📝 `src/fdcache_fdinfo.h` (+16 -13) </details> ### 📄 Description ### Relevant Issue (if applicable) #2493 #2487 #254 ### Details This was modified to minimize exclusive control of the `PseudoFdInfo::upload_id` variable. To achieve this, `IsUploadingHasLock()` is added, which does not hold the `IsUploading()` lock, to streamline the locking process on the caller side. As a result of this efficiency, it is no longer necessary to lock before calling `ParallelMultipartUpload()`. Please refer to the code for detailed differences. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>