[PR #2541] [MERGED] Use `std::shared_ptr` to refer to `FdEntity` #2606

New issue

Closed

opened 2026-03-04 02:06:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2541
Author: @gaul
Created: 10/12/2024
Status: ✅ Merged
Merged: 10/20/2024
Merged by: @ggtakec

Base: master ← Head: shared_ptr

📝 Commits (1)

c978c2b Use std::shared_ptr to refer to FdEntity

📊 Changes

4 files changed (+13 additions, -12 deletions)

View changed files

📝 src/fdcache.cpp (+6 -6)
📝 src/fdcache.h (+2 -2)
📝 src/fdcache_entity.cpp (+1 -1)
📝 src/fdcache_entity.h (+4 -3)

📄 Description

FdEntity may have multiple references due to ChangeEntityToTempPath. This relies on the std::enable_shared_from_this helper to create a std::shared_ptr from this. Fixes #2532.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2541 **Author:** [@gaul](https://github.com/gaul) **Created:** 10/12/2024 **Status:** ✅ Merged **Merged:** 10/20/2024 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `shared_ptr` --- ### 📝 Commits (1) - [`c978c2b`](https://github.com/s3fs-fuse/s3fs-fuse/commit/c978c2b00dafc976c2c788543118e48ecd6b0697) Use std::shared_ptr to refer to FdEntity ### 📊 Changes **4 files changed** (+13 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+6 -6) 📝 `src/fdcache.h` (+2 -2) 📝 `src/fdcache_entity.cpp` (+1 -1) 📝 `src/fdcache_entity.h` (+4 -3) </details> ### 📄 Description `FdEntity` may have multiple references due to `ChangeEntityToTempPath`. This relies on the `std::enable_shared_from_this` helper to create a `std::shared_ptr` from `this`. Fixes #2532. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>