[PR #2539] [MERGED] Fixed fake_diskfree option #2605

New issue

Closed

opened 2026-03-04 02:06:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2539
Author: @ggtakec
Created: 10/6/2024
Status: ✅ Merged
Merged: 10/6/2024
Merged by: @gaul

Base: master ← Head: fix/fake_diskfree

📝 Commits (1)

2fc88dd Fixed fake_diskfree option

📊 Changes

3 files changed (+58 additions, -50 deletions)

View changed files

📝 src/fdcache.cpp (+18 -19)
📝 src/fdcache.h (+8 -4)
📝 src/s3fs.cpp (+32 -27)

📄 Description

Relevant Issue (if applicable)

( #2538 is weakly related issues )

Details

The value of the fake_diskfree option was affected by the values of the free_space_ratio and ensure_diskfree options, and in some cases it could not be set.

Originally, fake_diskfree was an option for debugging s3fs, setting a pseudo amount of free disk space, so it should not have been affected by the results of the check of the amount of free space required when s3fs was started.

If the amount of free space was below the minimum required for multipart uploads, etc., it was unable to be set, but we have changed it so that it can be set without being affected by this condition.

When making this correction, we also found an error in the mutual exclusion control (mutex), so we have corrected that at the same time.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2539 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 10/6/2024 **Status:** ✅ Merged **Merged:** 10/6/2024 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/fake_diskfree` --- ### 📝 Commits (1) - [`2fc88dd`](https://github.com/s3fs-fuse/s3fs-fuse/commit/2fc88ddd3416caddbe010419703107aab8c3fcaa) Fixed fake_diskfree option ### 📊 Changes **3 files changed** (+58 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+18 -19) 📝 `src/fdcache.h` (+8 -4) 📝 `src/s3fs.cpp` (+32 -27) </details> ### 📄 Description ### Relevant Issue (if applicable) ( #2538 is weakly related issues ) ### Details The value of the `fake_diskfree` option was affected by the values of the `free_space_ratio` and `ensure_diskfree` options, and in some cases it could not be set. Originally, `fake_diskfree` was an option for debugging s3fs, setting a pseudo amount of free disk space, so it should not have been affected by the results of the check of the amount of free space required when s3fs was started. If the amount of free space was below the minimum required for multipart uploads, etc., it was unable to be set, but we have changed it so that it can be set without being affected by this condition. When making this correction, we also found an error in the mutual exclusion control (mutex), so we have corrected that at the same time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>