[PR #2531] [MERGED] Modified and bypassed some MacOS tests #2598

New issue

Closed

opened 2026-03-04 02:06:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2531
Author: @ggtakec
Created: 9/28/2024
Status: ✅ Merged
Merged: 9/29/2024
Merged by: @gaul

Base: master ← Head: fix/test_macos_patch

📝 Commits (1)

2b71cbd Modified and bypassed some MacOS tests

📊 Changes

1 file changed (+27 additions, -3 deletions)

View changed files

📝 test/integration-test-main.sh (+27 -3)

📄 Description

Relevant Issue (if applicable)

#2418 #2205 #2198

Details

Currently, we still unable to pass the tests on MacOS using macos-fuse-t.

After some investigation, I knew again that (as previously pointed out) our test cases were failing to update(or get) attributes such as ctime/mtime/atime.
We have disabled caching of attributes in macos-fuse-t and the NFS it uses (noattrcache), but we've heard before that this doesn't stop the caching completely.
I tried waiting a few second to try to cache out, but the test pass/fail is not consistent.

In light of this, I have temporarily disabled the following tests on macos.

test_update_directory_time_set_xattr
test_update_directory_time_subdir
test_update_parent_directory_time

Also, since the test_truncate_cache test generates an error ls: fts_read: Input/output error, I have changed this test waits 1 second for a solution to that problem. (This change is also temporary.)

I consider the test fix in this PR to be temporary, not permanent.

@gaul
Why don't you merge this?

@macos-fuse-t
If you have any updated info on these (which I think are affected by caches) please let us know.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2531 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 9/28/2024 **Status:** ✅ Merged **Merged:** 9/29/2024 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/test_macos_patch` --- ### 📝 Commits (1) - [`2b71cbd`](https://github.com/s3fs-fuse/s3fs-fuse/commit/2b71cbd2c25f51e019613c5aaa2ca497a432cf2e) Modified and bypassed some MacOS tests ### 📊 Changes **1 file changed** (+27 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `test/integration-test-main.sh` (+27 -3) </details> ### 📄 Description ### Relevant Issue (if applicable) #2418 #2205 #2198 ### Details Currently, we still unable to pass the tests on MacOS using macos-fuse-t. After some investigation, I knew again that (as previously pointed out) our test cases were failing to update(or get) attributes such as ctime/mtime/atime. _We have disabled caching of attributes in macos-fuse-t and the NFS it uses (noattrcache), but we've heard before that this doesn't stop the caching completely._ I tried waiting a few second to try to cache out, but the test pass/fail is not consistent. In light of this, I have temporarily disabled the following tests on macos. - test_update_directory_time_set_xattr - test_update_directory_time_subdir - test_update_parent_directory_time Also, since the `test_truncate_cache` test generates an error `ls: fts_read: Input/output error`, I have changed this test waits 1 second for a solution to that problem. (This change is also temporary.) I consider the test fix in this PR to be temporary, not permanent. @gaul Why don't you merge this? @macos-fuse-t If you have any updated info on these (which I think are affected by caches) please let us know. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>