[PR #2475] [MERGED] Changed the display format of the Git commit hash in the version display #2560

New issue

Closed

opened 2026-03-04 02:06:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2475
Author: @ggtakec
Created: 6/23/2024
Status: ✅ Merged
Merged: 6/23/2024
Merged by: @gaul

Base: master ← Head: change_ver_commit

📝 Commits (1)

814d4bd Changed the display format of the Git commit hash in the version display

📊 Changes

4 files changed (+25 additions, -10 deletions)

View changed files

📝 autogen.sh (+8 -4)
📝 configure.ac (+14 -3)
📝 src/s3fs.cpp (+1 -1)
📝 src/s3fs_help.cpp (+2 -2)

📄 Description

Relevant Issue (if applicable)

#2457

Details

Currently, the s3fs version display includes the git commit hash(short sha1).
However, in the s3fs distributed from the package repository, the commit hash value is unknown.

Because this unknown can be misleading, the version notation will be changed to the following depending on the environment in which s3fs was built.

If there is no git command or if the .git directory does not exist

The commit hash will not be displayed.

Amazon Simple Storage Service File System V1.94 with OpenSSL

If the git commit hash can be obtained

If there is no untracked file:

Amazon Simple Storage Service File System V1.94(commit:254d717) with OpenSSL

If there is an untracked file:

Amazon Simple Storage Service File System V1.94(commit:254d717 +untracked files) with OpenSSL

If the git commit hash cannot be obtained, but there is a `default_commit_hash` file

This case applies when extracting a distribution archive of source code created by make dist.

Amazon Simple Storage Service File System V1.94(base commit:254d717) with OpenSSL

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2475 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 6/23/2024 **Status:** ✅ Merged **Merged:** 6/23/2024 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `change_ver_commit` --- ### 📝 Commits (1) - [`814d4bd`](https://github.com/s3fs-fuse/s3fs-fuse/commit/814d4bd845a299d78d19b16e413cbf301eeb1421) Changed the display format of the Git commit hash in the version display ### 📊 Changes **4 files changed** (+25 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `autogen.sh` (+8 -4) 📝 `configure.ac` (+14 -3) 📝 `src/s3fs.cpp` (+1 -1) 📝 `src/s3fs_help.cpp` (+2 -2) </details> ### 📄 Description ### Relevant Issue (if applicable) #2457 ### Details Currently, the s3fs version display includes the git commit hash(short sha1). However, in the s3fs distributed from the package repository, the commit hash value is `unknown`. Because this `unknown` can be misleading, the version notation will be changed to the following depending on the environment in which s3fs was built. #### If there is no git command or if the .git directory does not exist The commit hash will not be displayed. ``` Amazon Simple Storage Service File System V1.94 with OpenSSL ``` #### If the git commit hash can be obtained - If there is no untracked file: ``` Amazon Simple Storage Service File System V1.94(commit:254d717) with OpenSSL ``` - If there is an untracked file: ``` Amazon Simple Storage Service File System V1.94(commit:254d717 +untracked files) with OpenSSL ``` #### If the git commit hash cannot be obtained, but there is a `default_commit_hash` file This case applies when extracting a distribution archive of source code created by `make dist`. ``` Amazon Simple Storage Service File System V1.94(base commit:254d717) with OpenSSL ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>