[PR #2461] [MERGED] Pass `const std::string` by reference #2548

New issue

Closed

opened 2026-03-04 02:06:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2461
Author: @gaul
Created: 5/27/2024
Status: ✅ Merged
Merged: 5/28/2024
Merged by: @ggtakec

Base: master ← Head: nits/stringref

📝 Commits (1)

72fe0a6 Pass const std::string by reference

📊 Changes

4 files changed (+17 additions, -17 deletions)

View changed files

📝 src/curl.h (+2 -2)
📝 src/fdcache.cpp (+6 -6)
📝 src/fdcache.h (+1 -1)
📝 src/s3fs.cpp (+8 -8)

📄 Description

This is more idiomatic than by pointer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2461 **Author:** [@gaul](https://github.com/gaul) **Created:** 5/27/2024 **Status:** ✅ Merged **Merged:** 5/28/2024 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `nits/stringref` --- ### 📝 Commits (1) - [`72fe0a6`](https://github.com/s3fs-fuse/s3fs-fuse/commit/72fe0a672dca8bb28f14bfd83bbdbb3752ffd93b) Pass const std::string by reference ### 📊 Changes **4 files changed** (+17 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.h` (+2 -2) 📝 `src/fdcache.cpp` (+6 -6) 📝 `src/fdcache.h` (+1 -1) 📝 `src/s3fs.cpp` (+8 -8) </details> ### 📄 Description This is more idiomatic than by pointer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>