[PR #2426] [CLOSED] Use `xmlFreeNsList` to deallocate `xmlNsPtr` #2533

New issue

Closed

opened 2026-03-04 02:06:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2426
Author: @gaul
Created: 3/5/2024
Status: ❌ Closed

Base: master ← Head: xml-free-ns-list

📝 Commits (1)

ea8109b Use xmlFreeNsList to deallocate xmlNsPtr

📊 Changes

2 files changed (+1 additions, -6 deletions)

View changed files

📝 src/s3fs.h (+0 -5)
📝 src/s3fs_xml.cpp (+1 -1)

📄 Description

Previously xmlFree only freed the top-level allocation and not the entire linked list. Multiple namespaces should be rare but perhaps some S3 implementations have both a global and local namespace. The xmlFree(void*) prototype hid the type mismatch.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2426 **Author:** [@gaul](https://github.com/gaul) **Created:** 3/5/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `xml-free-ns-list` --- ### 📝 Commits (1) - [`ea8109b`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ea8109bce04434011e67eeb3abe2c71a4fa44f8b) Use xmlFreeNsList to deallocate xmlNsPtr ### 📊 Changes **2 files changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.h` (+0 -5) 📝 `src/s3fs_xml.cpp` (+1 -1) </details> ### 📄 Description Previously `xmlFree` only freed the top-level allocation and not the entire linked list. Multiple namespaces should be rare but perhaps some S3 implementations have both a global and local namespace. The `xmlFree(void*)` prototype hid the type mismatch. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>