[PR #2379] [CLOSED] Changed to use devtoolset for building on CentOS 7 #2513

New issue

Closed

opened 2026-03-04 02:05:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2379
Author: @ggtakec
Created: 11/25/2023
Status: ❌ Closed

Base: master ← Head: fix_centos7

📝 Commits (1)

29cf161 Changed to use devtoolset for building on CentOS 7

📊 Changes

2 files changed (+22 additions, -0 deletions)

View changed files

📝 .github/workflows/ci.yml (+3 -0)
📝 .github/workflows/linux-ci-helper.sh (+19 -0)

📄 Description

Relevant Issue (if applicable)

#2377
#2328

Details

Migration to C++11 is being hampered by CentOS 7's lower version of GCC4(lack of support for std::get_time/put_time).
To avoid this, I changed to use devtoolset-11.
These template methods are implemented inline, so the devtoolset-11 environment is not required at runtime.
For the time being, we can use this method to eliminate differences with other OS.

@gaul
I think there may be no problem with this method.
Even if there are users who build on CentOS 7, I don't think it will be difficult to build an environment with devtoolset.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2379 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 11/25/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_centos7` --- ### 📝 Commits (1) - [`29cf161`](https://github.com/s3fs-fuse/s3fs-fuse/commit/29cf161d031958da1445a46144424af0a936553e) Changed to use devtoolset for building on CentOS 7 ### 📊 Changes **2 files changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+3 -0) 📝 `.github/workflows/linux-ci-helper.sh` (+19 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #2377 #2328 ### Details Migration to C++11 is being hampered by CentOS 7's lower version of GCC4(lack of support for std::get_time/put_time). To avoid this, I changed to use `devtoolset-11`. These template methods are implemented inline, so the `devtoolset-11` environment is not required at runtime. For the time being, we can use this method to eliminate differences with other OS. @gaul I think there may be no problem with this method. Even if there are users who build on CentOS 7, I don't think it will be difficult to build an environment with `devtoolset`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>