[PR #2343] [MERGED] Fixed ETag parsing at completing the Multipart upload part #2489

New issue

Closed

opened 2026-03-04 02:05:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2343
Author: @ggtakec
Created: 10/7/2023
Status: ✅ Merged
Merged: 10/13/2023
Merged by: @gaul

Base: master ← Head: fix_etag_bugs

📝 Commits (1)

fa21ca2 Fixed ETag parsing at completing the Multipart upload part

📊 Changes

6 files changed (+25 additions, -18 deletions)

View changed files

📝 src/curl.cpp (+4 -7)
📝 src/curl_util.cpp (+2 -10)
📝 src/curl_util.h (+1 -1)
📝 src/string_util.cpp (+8 -0)
📝 src/string_util.h (+1 -0)
📝 src/test_string_util.cpp (+9 -0)

📄 Description

Relevant Issue (if applicable)

n/a

Details

When completing a multipart upload(in the UploadMultipartPostComplete method) it was not possible to remove double quotes from the response ETag string.
But it was deleted in the similar CopyMultipartPostComplete, then mixed Etags(with/without double quotes) for Mix Multipart Upload.
So far, this doesn't cause uploads to fail, but I'd like to keep the specs the same.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2343 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 10/7/2023 **Status:** ✅ Merged **Merged:** 10/13/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_etag_bugs` --- ### 📝 Commits (1) - [`fa21ca2`](https://github.com/s3fs-fuse/s3fs-fuse/commit/fa21ca2fdfcac631a7f3c7c07312330a700ad4e7) Fixed ETag parsing at completing the Multipart upload part ### 📊 Changes **6 files changed** (+25 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+4 -7) 📝 `src/curl_util.cpp` (+2 -10) 📝 `src/curl_util.h` (+1 -1) 📝 `src/string_util.cpp` (+8 -0) 📝 `src/string_util.h` (+1 -0) 📝 `src/test_string_util.cpp` (+9 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details When completing a multipart upload(in the `UploadMultipartPostComplete` method) it was not possible to remove double quotes from the response ETag string. But it was deleted in the similar `CopyMultipartPostComplete`, then mixed Etags(with/without double quotes) for Mix Multipart Upload. So far, this doesn't cause uploads to fail, but I'd like to keep the specs the same. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>