[PR #2341] [MERGED] Force disk free space recovery in test(for only macos) #2488

New issue

Closed

opened 2026-03-04 02:05:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2341
Author: @ggtakec
Created: 10/7/2023
Status: ✅ Merged
Merged: 11/10/2023
Merged by: @gaul

Base: master ← Head: fix_add_sync_test

📝 Commits (1)

07c57c1 Force disk free space recovery in test(for only macos)

📊 Changes

1 file changed (+19 additions, -4 deletions)

View changed files

📝 test/integration-test-main.sh (+19 -4)

📄 Description

Relevant Issue (if applicable)

#2320

Details

In the test code that was pointed out in #2320, there was still a problem with the test_multipart_mix test on macos12.

Background

For macos, I was forcing the test file size to zero at the beginning of the test_multipart_mix, because this was to synchronize the free space area.
But it was detected that the free space may not be recovered immediately after deleting a file.
(Free space recovery may not be reflected in the results of the statvfs or df commands.)
I still don't know why this delay occurs.

Purpose

The code trying to recover free space on the current disk wasn't good enough.
The test_multipart_mix test repeatedly creates files of several tens MB.
In rare cases, you will run out of disk space and the test will fail (on macos12).
To reliably reproduce this, you can run only the test_multipart_mix test function repeatedly(dozens of times) on macos12.

Changing test code

Forces the test files and its cache files size to zero, and deletes them upon completion of the test_multipart_mix test.
And call sync command for disk.

So far, this fix has not caused any shortage of disk space (problem where free space is not restored).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2341 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 10/7/2023 **Status:** ✅ Merged **Merged:** 11/10/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_add_sync_test` --- ### 📝 Commits (1) - [`07c57c1`](https://github.com/s3fs-fuse/s3fs-fuse/commit/07c57c1d365d82f071c7c0689548fca048bead8c) Force disk free space recovery in test(for only macos) ### 📊 Changes **1 file changed** (+19 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `test/integration-test-main.sh` (+19 -4) </details> ### 📄 Description ### Relevant Issue (if applicable) #2320 ### Details In the test code that was pointed out in #2320, there was still a problem with the `test_multipart_mix` test on macos12. #### Background For macos, I was forcing the test file size to zero at the beginning of the `test_multipart_mix`, because this was to synchronize the free space area. But it was detected that the free space may not be recovered immediately after deleting a file. (Free space recovery may not be reflected in the results of the `statvfs` or `df` commands.) I still don't know why this delay occurs. #### Purpose The code trying to recover free space on the current disk wasn't good enough. The `test_multipart_mix test` repeatedly creates files of several tens MB. In rare cases, you will run out of disk space and the test will fail (on macos12). To reliably reproduce this, you can run only the `test_multipart_mix` test function repeatedly(dozens of times) on macos12. #### Changing test code Forces the test files and its cache files size to zero, and deletes them upon completion of the `test_multipart_mix` test. And call `sync` command for disk. So far, this fix has not caused any shortage of disk space (problem where free space is not restored). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>