[PR #2325] [MERGED] Fixed a bug upload boundary calculation in StreamUpload #2479

New issue

Closed

opened 2026-03-04 02:05:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2325
Author: @ggtakec
Created: 9/18/2023
Status: ✅ Merged
Merged: 9/25/2023
Merged by: @gaul

Base: master ← Head: fix_streamupload

📝 Commits (1)

9076d9d Fixed a bug upload boundary calculation in StreamUpload

📊 Changes

2 files changed (+72 additions, -1 deletions)

View changed files

📝 src/fdcache_fdinfo.cpp (+1 -1)
📝 test/integration-test-main.sh (+71 -0)

📄 Description

Relevant Issue (if applicable)

#2299

Details

Fixed the bug detected in #2299.

There was a problem in calculating the start position of the upload part during Streamupload, and it has been fixed.
We have also added a test case(test_not_boundary_writes) to detect this defect.
Although it is possible to include it in the test_write_data_with_skip test, I made it independent as a test case.

Note

Currently, Github Action CI is failing for this PR due to a stat(cached) issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2325 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 9/18/2023 **Status:** ✅ Merged **Merged:** 9/25/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_streamupload` --- ### 📝 Commits (1) - [`9076d9d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/9076d9d79ed489053f70250f47c5e0d62aa8c628) Fixed a bug upload boundary calculation in StreamUpload ### 📊 Changes **2 files changed** (+72 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_fdinfo.cpp` (+1 -1) 📝 `test/integration-test-main.sh` (+71 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #2299 ### Details Fixed the bug detected in #2299. There was a problem in calculating the start position of the upload part during Streamupload, and it has been fixed. We have also added a test case(`test_not_boundary_writes`) to detect this defect. _Although it is possible to include it in the `test_write_data_with_skip` test, I made it independent as a test case._ #### Note Currently, Github Action CI is failing for this PR due to a stat(cached) issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>